From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55956)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1ZpBun-0000C1-Nt
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 05:12:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1ZpBuj-0003Ft-LJ
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 05:12:05 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:36342 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1ZpBuj-0003Fc-BY
	for qemu-devel@nongnu.org; Thu, 22 Oct 2015 05:12:01 -0400
References: <1445501858-18790-1-git-send-email-famz@redhat.com>
	<1445501858-18790-2-git-send-email-famz@redhat.com>
	<56289ED9.1040401@kamp.de> <5628A239.8030600@redhat.com>
From: Peter Lieven <pl@kamp.de>
Message-ID: <5628A858.5030909@kamp.de>
Date: Thu, 22 Oct 2015 11:11:52 +0200
MIME-Version: 1.0
In-Reply-To: <5628A239.8030600@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error
	code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>

Am 22.10.2015 um 10:45 schrieb Paolo Bonzini:
>
> On 22/10/2015 10:31, Peter Lieven wrote:
>> +    switch (sense->key) {
>> +    case SCSI_SENSE_NO_SENSE:
>> +        return 0;
>> +        break;

Isn't it dangerous to return 0 (no error) if the status is != SCSI_STATUS_GOOD?

Peter