From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpGMg-0004U8-FI for qemu-devel@nongnu.org; Thu, 22 Oct 2015 09:57:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpGMc-0006bQ-DC for qemu-devel@nongnu.org; Thu, 22 Oct 2015 09:57:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpGMc-0006bM-7a for qemu-devel@nongnu.org; Thu, 22 Oct 2015 09:57:06 -0400 References: <1445509543-30679-1-git-send-email-berrange@redhat.com> <5628D505.20203@redhat.com> <20151022124215.GF9079@redhat.com> From: Eric Blake Message-ID: <5628EB30.2040400@redhat.com> Date: Thu, 22 Oct 2015 07:57:04 -0600 MIME-Version: 1.0 In-Reply-To: <20151022124215.GF9079@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GV8ACKlXKKTTowJD4OiVG1xx67fJXmOk0" Subject: Re: [Qemu-devel] [PATCH] qapi-schema: mark InetSocketAddress as mandatory again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Paolo Bonzini , qemu-devel@nongnu.org, Knut Omang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GV8ACKlXKKTTowJD4OiVG1xx67fJXmOk0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/22/2015 06:42 AM, Daniel P. Berrange wrote: >>> +++ b/qapi-schema.json >>> @@ -2614,9 +2614,7 @@ >>> # >>> # @host: host part of the address >>> # >>> -# @port: port part of the address, or lowest port if @to is present.= >>> -# Kernel selects a free port if omitted for listener addresse= s. >>> -# #optional >>> +# @port: port part of the address, or lowest port if @to is present >> >> Don't you still want to allow an empty string as the way to allow kern= el >> port selection? >=20 > I only needed the support for empty port for the sake of the unit > tests, which doesn't use QAPI parsing code. Enabling it via the command= > line / monitor was just a happy accident, so I figure this is fine for > 2.5. We can re-revert it in 2.6 when you change the QAPI generator Fair enough; then you can add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GV8ACKlXKKTTowJD4OiVG1xx67fJXmOk0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWKOswAAoJEKeha0olJ0NqAZUH/iC8zqYODIndMbs7yk+6wUjX qEUn3ln4IWuQNkyMCn6VqglQ/UIYCw2oHDjw5tF0zjRt8Xx1snu0/lr2tV0ALqzN 5L1L1MESErC0T0dplRV0WVBBkvpVB4uCHB6qnPNqfZoVqQoBWwyDraMTRPtO03I/ c3hFbHfbz3GiIQ4l5Io6g1GCYLFsh0q38FyeIrvBl0p3gjOv27xWso70aG/KA1Fb cvBgke0Z4uooP+/IBXY8iRm5nVLPJgYTSbxw5VXSaYaFAUX/BEvIWuu6oHY0afXi FGA3B5n4sJlCqtwU2PLgn4bynuH3HDPbBbfaYw4Bqdlr7137gRLx0ZOg8igHkwE= =hM8b -----END PGP SIGNATURE----- --GV8ACKlXKKTTowJD4OiVG1xx67fJXmOk0--