From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpGpC-0007f8-SR for qemu-devel@nongnu.org; Thu, 22 Oct 2015 10:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpGpB-00083H-Oe for qemu-devel@nongnu.org; Thu, 22 Oct 2015 10:26:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpGpB-00083B-Id for qemu-devel@nongnu.org; Thu, 22 Oct 2015 10:26:37 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4F6EBFC0F9 for ; Thu, 22 Oct 2015 14:26:37 +0000 (UTC) References: <1444968943-11254-1-git-send-email-eblake@redhat.com> <1444968943-11254-16-git-send-email-eblake@redhat.com> <87r3knyoix.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <5628F21B.5050700@redhat.com> Date: Thu, 22 Oct 2015 08:26:35 -0600 MIME-Version: 1.0 In-Reply-To: <87r3knyoix.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="op70GrlJDTr0IRevV7ljoMno0hPIcL1lX" Subject: Re: [Qemu-devel] [PATCH v9 15/17] tpm: Convert to new qapi union layout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --op70GrlJDTr0IRevV7ljoMno0hPIcL1lX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/22/2015 08:19 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> We have two issues with our qapi union layout: >> 1) Even though the QMP wire format spells the tag 'type', the >> C code spells it 'kind', requiring some hacks in the generator. >> 2) The C struct uses an anonymous union, which places all tag >> values in the same namespace as all non-variant members. This >> leads to spurious collisions if a tag value matches a QMP name. >> >> Make the conversion to the new layout for TPM-related code. >> >> Signed-off-by: Eric Blake >=20 > PATCH 08-15 appear to be a purely mechanical switch to u. and from kind= > to type, except for a qapi.py hunk that looks like it should be in PATC= H > 07, and a comment update to tests/qapi-schema/union-clash-type.json. > Did I miss anything? >=20 > Combined diffstat isn't so bad: >=20 > 36 files changed, 393 insertions(+), 394 deletions(-) It already needs a rebase; some of Dan's work has caused more changes to ui/vnc.c and util/qemu-sockets.c. So hopefully I post v10 soon. >=20 > I've seen worse tree-wide changes, some of them my own. I'd be tempted= > to squash the complete switch together. But squashing is easy, so we > can keep it separate while we review, and decide when we're done. Sure, v10 will keep things separate, but squashing won't hurt too much. After all, v5 had it all as one patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --op70GrlJDTr0IRevV7ljoMno0hPIcL1lX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWKPIcAAoJEKeha0olJ0Nq+m4H+wWhvWeA7CdxBHC/+JqVaQWr xRnTXDKfUrEXrz15m5tdgnfHE5M36V3rRx1tZ9/iVp4ZeTtQmV47I3EeZna1WlX4 spZQy3nbwfWltJvlvor8uVcip0ImhQfWKe1/y2vImFstbevZx5+TP4Y8EJKsLIXY 2KACPyDT5Gl3jtHlA1aITxrAFpxL8rCxNsCUgn0gaFYXWCIeL0yNsPftShAMIEyo SiCXH6/byQunviJ4JNKTJOKShk7DeW5bXMfg+3T2rew6x4JKVtd12CPA3IhtM879 FiSwM4JD+vCDQsiQMwDWilVPPbdSrTUZgLAanBJP923DUOtn1W1jWm+m6rT2rRU= =3fXe -----END PGP SIGNATURE----- --op70GrlJDTr0IRevV7ljoMno0hPIcL1lX--