From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpRUl-0001vg-Eh for qemu-devel@nongnu.org; Thu, 22 Oct 2015 21:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpRUh-0006gh-CA for qemu-devel@nongnu.org; Thu, 22 Oct 2015 21:50:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpRUh-0006gd-7X for qemu-devel@nongnu.org; Thu, 22 Oct 2015 21:50:11 -0400 References: <1444968943-11254-1-git-send-email-eblake@redhat.com> <1444968943-11254-6-git-send-email-eblake@redhat.com> <8737x591xz.fsf@blackfin.pond.sub.org> <56266704.2060403@redhat.com> <87pp08ny5g.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <5629924D.9050400@redhat.com> Date: Thu, 22 Oct 2015 19:50:05 -0600 MIME-Version: 1.0 In-Reply-To: <87pp08ny5g.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="usjCv6QNlhtJmP4seWlOLgLBtlEqhxHdP" Subject: Re: [Qemu-devel] [PATCH v9 05/17] qapi: Unbox base members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --usjCv6QNlhtJmP4seWlOLgLBtlEqhxHdP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/21/2015 07:34 AM, Markus Armbruster wrote: >=20 > The least verbose naming convention for a conversion function I can > think of right now is TBase(), where T is the name of a type with a > base. Compare: >=20 > foo((Parent *)child, blah) > foo(ChildBase(child), blah) >=20 > Tolerable? Worthwhile? 'TBase' won't work. We already have BlockdevOptionsBase as a subtype of BlockdevOptions, and using 'TBase' would give us 'BlockdevOptionsBase(options)' which is now ambiguous between the type name and intended function call. I'll probably go with qapi_TYPE_base(), and see how long that looks. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --usjCv6QNlhtJmP4seWlOLgLBtlEqhxHdP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWKZJNAAoJEKeha0olJ0NqKfgH/AsX42N3WT099XMJiYtP64mV Bk1bHndlmGFhMg7glG1uCZRpuzpQ5CVSUDmUMBjy5omQY6U1ecRfqlakApJ4+tsW KWWSUIgZGuYq0pT845DrkQekmfOIz2242O+7ybP9kQ82mwhpwXzK0qrFoJ5AJC+E 1+bZC7QSaSVtGJ5KkBIdv/EyItxK1uP7b3SmAMycj9eksMkbvcAUcUArRa7VRJdg /Rb64fGbWPyUMoRl0p9GIbiesVVuucdQmI/z5XjluZjupgjB6Z+2Cc9ENs9pOzkx FLf4exWerU+LkS51n9gcd/9HfE7VJU8Jw+sextBXti15pvWC7Wy99YvFPtb5UEk= =d5cq -----END PGP SIGNATURE----- --usjCv6QNlhtJmP4seWlOLgLBtlEqhxHdP--