qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE
Date: Fri, 23 Oct 2015 13:14:34 +0300	[thread overview]
Message-ID: <562A088A.3030905@gmail.com> (raw)
In-Reply-To: <CAFEAcA9MT7FOBWmNR+6RA10R8hxA9qYACXADbtAqxGuZbCt_hA@mail.gmail.com>

On 23.10.2015 00:28, Peter Maydell wrote:
> On 22 October 2015 at 19:28, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
>> Hi all,
>>
>> I am trying to understand what the difference should be between
>> DISAS_JUMP and DISAS_UPDATE. Actually, these macros have comments in
>> include/exec/exec-all.h which say that DISAS_JUMP should be used when
>> only PC was modified dynamically whereas DISAS_UPDATE should be used
>> when some other CPU state was (in addition to PC?) modified dynamically.
>> In fact, every target except ARM AArch64 does not distinguish between
>> them. As I can see ARM AArch64 seems to suppose that: (1) PC was not
>> modified when DISAS_UPDATE is used and should be updated with dc->pc
>> when finishing translation; (2) DISAS_JUMP can be used to indicate that
>> a new PC value was set and it should be preserved when finishing
>> translation.
> As Richard says, (a) the semantics for these values are really
> private to each translator (b) the general idea is how AArch64
> uses them. I think the 32-bit ARM code does something a bit odd
> because it has to handle conditional execution (some things we
> might have otherwise done immediately in the decode function
> get postponed to the end of the loop). Mostly I haven't messed
> around too much with that bit of the code because it works
> and it's kind of complicated to understand. But the AArch64
> stuff we wrote from scratch so it does things in the straightforward
> way.

Thanks, Peter. What if I am going to modify DISAS_JUMP and DISAS_UPDATE
usage in 32-bit ARM code and apply AArch64 semantics to them?

Best,
Sergey

  reply	other threads:[~2015-10-23 10:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 18:28 [Qemu-devel] exec: About DISAS_JUMP and DISAS_UPDATE Sergey Fedorov
2015-10-22 19:50 ` Richard Henderson
2015-10-22 21:28 ` Peter Maydell
2015-10-23 10:14   ` Sergey Fedorov [this message]
2015-10-23 11:10     ` Peter Maydell
2015-10-23 12:35       ` Sergey Fedorov
2015-10-23 12:37         ` Peter Maydell
2015-10-23 12:39           ` Sergey Fedorov
2015-10-23 12:41             ` Peter Maydell
2015-10-27 17:47               ` Sergey Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562A088A.3030905@gmail.com \
    --to=serge.fdrv@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).