From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpcxI-0003Em-MC for qemu-devel@nongnu.org; Fri, 23 Oct 2015 10:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpcxD-0002vW-1p for qemu-devel@nongnu.org; Fri, 23 Oct 2015 10:04:28 -0400 References: <1445270025-22999-1-git-send-email-mreitz@redhat.com> <1445270025-22999-32-git-send-email-mreitz@redhat.com> <5627978B.3090403@redhat.com> <20151023133912.GD3797@noname.redhat.com> From: Max Reitz Message-ID: <562A3E56.3030603@redhat.com> Date: Fri, 23 Oct 2015 16:04:06 +0200 MIME-Version: 1.0 In-Reply-To: <20151023133912.GD3797@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pi9gPrD7pwApw3ObQ2kTssoRFf35uD7Co" Subject: Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Alberto Garcia , qemu-block@nongnu.org, John Snow , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pi9gPrD7pwApw3ObQ2kTssoRFf35uD7Co Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 23.10.2015 15:39, Kevin Wolf wrote: > Am 21.10.2015 um 15:47 hat Max Reitz geschrieben: >> On 21.10.2015 13:49, Alberto Garcia wrote: >>> On Mon 19 Oct 2015 05:53:37 PM CEST, Max Reitz wrote: >>>> And a helper function for that, which directly takes a pointer to th= e >>>> BDS to be inserted instead of its node-name (which will be used for >>>> implementing 'change' using blockdev-insert-medium). >>> >>> Shouldn't this update bdrv_states? >> >> I hate bdrv_states. >> >> Yes, it should. Thanks! >=20 > Once your reimplement blk_set_bs() on top of blk_insert/remove_bs(), > this logic would replace the code in change_parent_backing_link(). >=20 > Of course, I left the list update in block.c for a reason, it's meant t= o > be an internal data structure, so your code accessing it from outside > won't be much nicer. Do we actually still need bdrv_states or can we ge= t > rid of it in a follow-up series? If so, I wouldn't mind an ugly > intermediate state. I do get rid of it in "blockdev: Further BlockBackend work"* (the final patch of that series). Max * http://lists.nongnu.org/archive/html/qemu-block/2015-02/msg00021.html --pi9gPrD7pwApw3ObQ2kTssoRFf35uD7Co Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWKj5WAAoJEDuxQgLoOKytQNIH+gOOrXoKCI9xYmjrSKPpW5Mn lsF/kbCXR6Lbv7scgTul+/udnD3A1koUw4uedsZNyeJNuJyN0xkCs/vHs3u7eAQB Y9Gii27bjXq4dUR2HzxG+GCJnfYYi+D2RmvggktIWICEvi0njvIJZ7hHzvPNacMg YSi2nQ/4QsWbVlEBX8vMxwLfq9ndLqi/1lub8L+Gyb1Qiibu13KiF2FXIDnQZ6VT 50MfTtr198C/bIwDF21IcLg795QCEodSPPt5ERFRCstIMvIUaVbK9smtUjL3j5va MyFJPadZkkyW8LYM42rPv2A8N1ICh2dppq7OKuqBbvmhO2sZnoEF7RMQG7V80Rc= =k9Xx -----END PGP SIGNATURE----- --pi9gPrD7pwApw3ObQ2kTssoRFf35uD7Co--