From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqF41-0005W3-M6 for qemu-devel@nongnu.org; Sun, 25 Oct 2015 02:45:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqF3w-000674-OB for qemu-devel@nongnu.org; Sun, 25 Oct 2015 02:45:57 -0400 Received: from mga11.intel.com ([192.55.52.93]:46714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqF3w-00066x-IF for qemu-devel@nongnu.org; Sun, 25 Oct 2015 02:45:52 -0400 Message-ID: <562C7A99.3030101@intel.com> Date: Sun, 25 Oct 2015 14:45:45 +0800 From: "Lan, Tianyu" MIME-Version: 1.0 References: <1445445464-5056-1-git-send-email-tianyu.lan@intel.com> <1445445464-5056-6-git-send-email-tianyu.lan@intel.com> <5627FB20.3020003@gmail.com> <562BA729.10903@intel.com> <562C7098.4030406@gmail.com> In-Reply-To: <562C7098.4030406@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC Patch 05/12] IXGBE: Add new sysfs interface of "notify_vf" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Duyck , bhelgaas@google.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, eddie.dong@intel.com, nrupal.jani@intel.com, yang.z.zhang@intel.com, agraf@suse.de, kvm@vger.kernel.org, pbonzini@redhat.com, qemu-devel@nongnu.org, emil.s.tantilov@intel.com, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, john.ronciak@intel.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, matthew.vick@intel.com, mitch.a.williams@intel.com, netdev@vger.kernel.org, shannon.nelson@intel.com On 10/25/2015 2:03 PM, Alexander Duyck wrote: > On 10/24/2015 08:43 AM, Lan, Tianyu wrote: >> >> On 10/22/2015 4:52 AM, Alexander Duyck wrote: >>> Also have you even considered the MSI-X configuration on the VF? I >>> haven't seen anything anywhere that would have migrated the VF's MSI-X >>> configuration from BAR 3 on one system to the new system. >> >> MSI-X migration is done by Hypervisor(Qemu). >> Following link is my Qemu patch to do that. >> http://marc.info/?l=kvm&m=144544706530484&w=2 > > I really don't like the idea of trying to migrate the MSI-X across from > host to host while it is still active. I really think Qemu shouldn't be > moving this kind of data over in a migration. Hi Alex: VF MSI-X regs in the VM are faked by Qemu and Qemu maps host vectors of VF with guest's vector. The MSIX data migrated are for faked regs rather than the one on the host. After migration, Qemu will remap guest vectors with host vectors on the new machine. Moreover, VM is stopped during migrating MSI-X data. > > I think that having the VF do a suspend/resume is the best way to go. > Then it simplifies things as all you have to deal with is the dirty page > tracking for the Rx DMA and you should be able to do this without making > things too difficult. > Yes, that will be simple and most concern is service down time. I will test later. > - Alex