qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: den@openvz.org, armbru@redhat.com, stefanha@redhat.com,
	peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging
Date: Mon, 26 Oct 2015 10:16:50 +0900	[thread overview]
Message-ID: <562D7F02.5090200@de.ibm.com> (raw)
In-Reply-To: <1445779929-12237-1-git-send-email-pbonzini@redhat.com>

Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> This series does three things:
> 
> 1) add a "-trace [enable=]foo" option to enable one or more trace
> events, and a "-trace help" option to show the list of tracepoints
> (patches 4-5)
> 
> 2) change the stderr tracing backend so that it prints to the
> -D log file, and enable it by default.  "-trace file=..." is
> now a synonym of -D if the log backend is enabled (patches 7-8)
> 
> 3) add a "-d trace:foo" option that is a synonym for "-trace foo";
> this makes the new functionality more discoverable to people used
> to "-d", makes it available for user-mode emulation (which does
> not have -trace), and is somewhat nice if you want to enable both
> tracepoints and some other "-d" flag (patch 9).  When globbing
> it is also less susceptible to unwanted shell expansion.
> 
> For example, you can trace block device I/O and save the result
> to a file just by adding "-trace bdrv_aio_*,file=trace.txt", or
> correlate it to guest PCs with "-d exec,nochain,trace:bdrv_aio_*".
> 
> Opinions?  I would like to have this in 2.5 if there is agreement.

Can you also fixup qemu-io, qemu-nbd and so on?
I get errors like

libqemuutil.a(oslib-posix.o): In function `trace_qemu_memalign':
/home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:21: undefined reference to `qemu_log_mask'
libqemuutil.a(oslib-posix.o): In function `trace_qemu_anon_ram_alloc':
/home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:33: undefined reference to `qemu_log_mask'
libqemuutil.a(oslib-posix.o): In function `trace_qemu_vfree':
/home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:45: undefined reference to `qemu_log_mask'
libqemuutil.a(oslib-posix.o): In function `trace_qemu_anon_ram_free':
/home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:57: undefined reference to `qemu_log_mask'
collect2: error: ld returned 1 exit status
Makefile:302: recipe for target 'qemu-ga' failed

  parent reply	other threads:[~2015-10-26  1:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 13:32 [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 1/9] trace: fix documentation Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 2/9] trace: split trace_init_events out of trace_init_backends Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 3/9] trace: split trace_init_file " Paolo Bonzini
2015-10-26  1:03   ` Christian Borntraeger
2015-10-25 13:32 ` [Qemu-devel] [PATCH 4/9] trace: add "-trace enable=..." Paolo Bonzini
2015-10-25 13:32 ` [Qemu-devel] [PATCH 5/9] trace: add "-trace help" Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 6/9] log: do not unnecessarily include qom/cpu.h Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 7/9] trace: convert stderr backend to log Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 8/9] trace: switch default backend to "log" Paolo Bonzini
2015-10-25 13:35 ` [Qemu-devel] [PATCH 9/9] log: add "-d trace:PATTERN" Paolo Bonzini
2015-10-25 13:57 ` [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging Peter Maydell
2015-10-25 14:39   ` Paolo Bonzini
2015-10-26  1:16 ` Christian Borntraeger [this message]
2015-10-26  1:28 ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562D7F02.5090200@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).