From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqWPd-0001TR-Cv for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:17:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqWPY-0004ua-DT for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:17:25 -0400 Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:38215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqWPY-0004uP-46 for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:17:20 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Oct 2015 01:17:18 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7BA5917D8056 for ; Mon, 26 Oct 2015 01:17:27 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9Q1HGWI9437542 for ; Mon, 26 Oct 2015 01:17:16 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9Q1HG7r023616 for ; Sun, 25 Oct 2015 19:17:16 -0600 References: <1445779929-12237-1-git-send-email-pbonzini@redhat.com> From: Christian Borntraeger Message-ID: <562D7F02.5090200@de.ibm.com> Date: Mon, 26 Oct 2015 10:16:50 +0900 MIME-Version: 1.0 In-Reply-To: <1445779929-12237-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: den@openvz.org, armbru@redhat.com, stefanha@redhat.com, peter.maydell@linaro.org Am 25.10.2015 um 22:32 schrieb Paolo Bonzini: > This series does three things: > > 1) add a "-trace [enable=]foo" option to enable one or more trace > events, and a "-trace help" option to show the list of tracepoints > (patches 4-5) > > 2) change the stderr tracing backend so that it prints to the > -D log file, and enable it by default. "-trace file=..." is > now a synonym of -D if the log backend is enabled (patches 7-8) > > 3) add a "-d trace:foo" option that is a synonym for "-trace foo"; > this makes the new functionality more discoverable to people used > to "-d", makes it available for user-mode emulation (which does > not have -trace), and is somewhat nice if you want to enable both > tracepoints and some other "-d" flag (patch 9). When globbing > it is also less susceptible to unwanted shell expansion. > > For example, you can trace block device I/O and save the result > to a file just by adding "-trace bdrv_aio_*,file=trace.txt", or > correlate it to guest PCs with "-d exec,nochain,trace:bdrv_aio_*". > > Opinions? I would like to have this in 2.5 if there is agreement. Can you also fixup qemu-io, qemu-nbd and so on? I get errors like libqemuutil.a(oslib-posix.o): In function `trace_qemu_memalign': /home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:21: undefined reference to `qemu_log_mask' libqemuutil.a(oslib-posix.o): In function `trace_qemu_anon_ram_alloc': /home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:33: undefined reference to `qemu_log_mask' libqemuutil.a(oslib-posix.o): In function `trace_qemu_vfree': /home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:45: undefined reference to `qemu_log_mask' libqemuutil.a(oslib-posix.o): In function `trace_qemu_anon_ram_free': /home/cborntra/REPOS/qemu/build/./trace/generated-tracers.h:57: undefined reference to `qemu_log_mask' collect2: error: ld returned 1 exit status Makefile:302: recipe for target 'qemu-ga' failed