From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqlFY-0000WF-MP for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqlFV-0002dp-GL for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:08:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqlFV-0002di-A8 for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:07:57 -0400 References: <1445850626-29407-1-git-send-email-den@openvz.org> <1445850841-29510-1-git-send-email-den@openvz.org> <1445850841-29510-2-git-send-email-den@openvz.org> <87io5tu62s.fsf@fimbulvetr.bsc.es> From: Eric Blake Message-ID: <562E5DEB.2070009@redhat.com> Date: Mon, 26 Oct 2015 11:07:55 -0600 MIME-Version: 1.0 In-Reply-To: <87io5tu62s.fsf@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AcE4svjGUKIEeaxMtxSXl7XoEPR85827e" Subject: Re: [Qemu-devel] [PATCH 11/11] log: add "-d trace:PATTERN" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AcE4svjGUKIEeaxMtxSXl7XoEPR85827e Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/26/2015 07:12 AM, Llu=C3=ADs Vilanova wrote: > Denis V Lunev writes: >=20 >> From: Paolo Bonzini >> This is a bit easier to use than "-trace" if you are also enabling >> other kinds of logging. It is also more discoverable for experienced >> QEMU users, and accessible from user-mode emulators. >=20 > I'm not sure this should be added, since the same functionality is also= > available through "-trace enable=3D" (and the shortcut "-trace= > "). Having more than one way to do something is not necessarily bad; it does imply more maintenance to keep both ways working, but if one way is more discoverable than the other it may be worth it. >=20 > Also, I'd rather fold event name discovery into "-trace enable=3D?" (an= d the > shortcut "-trace ?"), mimicking the format already available for CPUs (= "-cpu > ?"). >=20 If we do that, we should also support '-trace enable=3Dhelp', because ? i= s a shell metacharacter, and we have been moving towards using 'help' rather than '?' to minimize the need for shell quoting when asking for he= lp. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AcE4svjGUKIEeaxMtxSXl7XoEPR85827e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWLl3rAAoJEKeha0olJ0NqkZEH/Ag6nxcDcgo8SFe92w4eNjnB BzXQqPFpBpmwg44GB1PJ5kCLPc3bnZvA/lndWkYVp/dwOQmJPFQF7IcyrjktfduZ r0LvFJl6uTGefe1ZdQhYQaJjkSRL9KU1WRnPtkJCP9Fy1BkceckS1NsJdpyuuDGs 0jFsz7vIPP80I1ES8ltAtzo673CP3XVLKa87mfNZCQm0T4QdRCbGTqo9lIKdOPRV gwIlK2QiUabu5B6wVfvZVq2hXElf+t+9S0lVyNRmoM1pEhQXs56/6UAkOQckMjLe 90V30LNa2Xtr8M2DMJM417VjHWVLeziAoafX1BwqcIa1TCrNn2Y1c3GFg3N4dlg= =orUX -----END PGP SIGNATURE----- --AcE4svjGUKIEeaxMtxSXl7XoEPR85827e--