From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqlQI-0007dh-MG for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqlQD-0005Mk-Op for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:19:06 -0400 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:32775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqlQD-0005Mg-J6 for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:19:01 -0400 Received: by pabla5 with SMTP id la5so882510pab.0 for ; Mon, 26 Oct 2015 10:19:00 -0700 (PDT) Sender: Paolo Bonzini References: <1445850626-29407-1-git-send-email-den@openvz.org> <1445850626-29407-5-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <562E607F.7020105@redhat.com> Date: Mon, 26 Oct 2015 18:18:55 +0100 MIME-Version: 1.0 In-Reply-To: <1445850626-29407-5-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/11] trace: no need to call trace_backend_init in different branches now List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 26/10/2015 10:10, Denis V. Lunev wrote: > original idea to split calling locations was to trace tracing thread > in the final child process according to > > commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad > Author: Michael Mueller > Date: Mon Sep 23 16:36:54 2013 +0200 > > os_daemonize is now on top of both locations. Drop unneeded ifs. Oh, that's nice! :-) Reviewed-by: Paolo Bonzini Paolo > Signed-off-by: Denis V. Lunev > --- > vl.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/vl.c b/vl.c > index b1ddd3f..7ce9d70 100644 > --- a/vl.c > +++ b/vl.c > @@ -4083,10 +4083,8 @@ int main(int argc, char **argv, char **envp) > qemu_set_log(mask); > } > > - if (!is_daemonized()) { > - if (!trace_init_backends()) { > - exit(1); > - } > + if (!trace_init_backends()) { > + exit(1); > } > > /* If no data_dir is specified then try to find it relative to the > @@ -4635,12 +4633,6 @@ int main(int argc, char **argv, char **envp) > > os_setup_post(); > > - if (is_daemonized()) { > - if (!trace_init_backends()) { > - exit(1); > - } > - } > - > main_loop(); > bdrv_close_all(); > pause_all_vcpus(); >