From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqlRw-0001cr-OG for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:20:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqlRr-0005rL-Ou for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:20:48 -0400 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:34872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqlRr-0005rE-Jk for qemu-devel@nongnu.org; Mon, 26 Oct 2015 13:20:43 -0400 Received: by pasz6 with SMTP id z6so193875319pas.2 for ; Mon, 26 Oct 2015 10:20:42 -0700 (PDT) Sender: Paolo Bonzini References: <1445850626-29407-1-git-send-email-den@openvz.org> <1445850626-29407-9-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <562E60E4.1060900@redhat.com> Date: Mon, 26 Oct 2015 18:20:36 +0100 MIME-Version: 1.0 In-Reply-To: <1445850626-29407-9-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/11] log: move qemu-log.c into util/ directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 26/10/2015 10:10, Denis V. Lunev wrote: > log will become common facility with tracepoints support in next step. > > Signed-off-by: Denis V. Lunev > --- > Makefile.objs | 1 - > util/Makefile.objs | 1 + > qemu-log.c => util/log.c | 0 > 3 files changed, 1 insertion(+), 1 deletion(-) > rename qemu-log.c => util/log.c (100%) > > diff --git a/Makefile.objs b/Makefile.objs > index ecfe03c..ce32193 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -81,7 +81,6 @@ endif > > ####################################################################### > # Target-independent parts used in system and user emulation > -common-obj-y += qemu-log.o > common-obj-y += tcg-runtime.o > common-obj-y += hw/ > common-obj-y += qom/ > diff --git a/util/Makefile.objs b/util/Makefile.objs > index d7cc399..a11915c 100644 > --- a/util/Makefile.objs > +++ b/util/Makefile.objs > @@ -29,3 +29,4 @@ util-obj-y += qemu-coroutine.o qemu-coroutine-lock.o qemu-coroutine-io.o > util-obj-y += qemu-coroutine-sleep.o > util-obj-y += coroutine-$(CONFIG_COROUTINE_BACKEND).o > util-obj-y += buffer.o > +util-obj-y += log.o > diff --git a/qemu-log.c b/util/log.c > similarity index 100% > rename from qemu-log.c > rename to util/log.c > Yes, this makes sense after the previous patch. The declaration of the LOG_* constants is a bit ad hoc for util/, but I guess it's fine. Another possibility is to move it to trace/. I'll leave this to Stefan to judge. Reviewed-by: Paolo Bonzini Paolo