From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqolo-0008CH-B0 for qemu-devel@nongnu.org; Mon, 26 Oct 2015 16:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqolj-0004qW-Ct for qemu-devel@nongnu.org; Mon, 26 Oct 2015 16:53:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqolj-0004qS-6o for qemu-devel@nongnu.org; Mon, 26 Oct 2015 16:53:27 -0400 References: <1445576998-2921-1-git-send-email-eblake@redhat.com> <1445576998-2921-10-git-send-email-eblake@redhat.com> <87lhatbo1o.fsf@blackfin.pond.sub.org> <562A9C46.8010909@redhat.com> <87r3ki2iev.fsf@blackfin.pond.sub.org> <562E53D8.4050205@redhat.com> <871tchplc4.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <562E92C0.4040000@redhat.com> Date: Mon, 26 Oct 2015 14:53:20 -0600 MIME-Version: 1.0 In-Reply-To: <871tchplc4.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Vb4tv418gGFsfvJdbt5ig3r0MjVLnPJs" Subject: Re: [Qemu-devel] [PATCH v10 09/25] qapi: Prefer typesafe upcasts to qapi base classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Vb4tv418gGFsfvJdbt5ig3r0MjVLnPJs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/26/2015 11:54 AM, Markus Armbruster wrote: >> It sounds like I have two options for v11: >> >> 1. Keep 9/25 introducing gen_upcast(), just for union types, and >> including testsuite coverage. In 10/25, make use of the upcast functio= ns >> to struct as part of making structs sane. >> >> 2. Swap the patch order: do 10/25 to alter struct layout first, using >> ugly casts; then implement 9/25 that adds gen_upcast() and fixes the >> ugly casts to instead use the new upcast functions. >> >> I can go either way, so do you have any preference? >=20 > I think I'd 3. Do 10/25 first, with gen_upcast() squashed in, and used > for casts to base. That gen_upcast() will just work for unions, too. > Least churn. I actually started with option 3 back when first writing v10, then decided that it made the patch big enough, and the addition was orthogonal enough, to go with the split patches at the time I actually posted v10. >=20 > But any of the three options should work. Good. Because I had already gone with option 1 locally before asking the question, which means now I don't have to respin to get option 2 or 3= :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9Vb4tv418gGFsfvJdbt5ig3r0MjVLnPJs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWLpLBAAoJEKeha0olJ0Nq3IMIAIjvhG8dB1p5h+wnSaTcu8QW ESPEj7uFwfQMFn+AhmKpYbuBTFgrPZk9vpe4OTy659P8tXHZLsoNF/gV+uQPvt+Q J+/RiDDRPskUGIgT5/WoG1UTuKV8LjHbQfIoJppzSXSrKTHC2y1WZlHB3KAiUjBb nNeZ2Rm2TE6nMlA+QFM9Rvlbope3NETkGePrpUhZmHhv4RHfnT7VgLgkr4DvpNhM LOPbT4HHP7bltyEyPH4HcSKVCejDQ2fgklNwDBZaCHrweP8hFHnN47NMdNsngKfC AlR5phsebHAlzWBbdXxXow+sYNpJRFUyhCUzvbzUDZCAHkzT56rSeoUTiqFRcAE= =+5NN -----END PGP SIGNATURE----- --9Vb4tv418gGFsfvJdbt5ig3r0MjVLnPJs--