From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Cc: 'Eduardo Habkost' <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT
Date: Tue, 27 Oct 2015 13:28:37 +0100 [thread overview]
Message-ID: <562F6DF5.3060509@redhat.com> (raw)
In-Reply-To: <013901d110b0$98f81a20$cae84e60$@samsung.com>
On 27/10/2015 13:11, Pavel Fedin wrote:
> + if ((backend->policy != MPOL_DEFAULT) || (errno != ENOSYS)) {
Can you remove parentheses around conditions?
Paolo
> + error_setg_errno(errp, errno,
> "cannot bind memory to host NUMA nodes");
> - return;
> + return;
next prev parent reply other threads:[~2015-10-27 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 12:11 [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT Pavel Fedin
2015-10-27 12:28 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-27 12:51 Pavel Fedin
2015-10-27 12:53 ` Pavel Fedin
2015-10-27 17:31 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F6DF5.3060509@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).