From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zr3Mv-0003qY-Ky
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 08:28:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zr3Mr-0004km-LY
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 08:28:49 -0400
Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:36770)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zr3Mr-0004kf-FO
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 08:28:45 -0400
Received: by pacfv9 with SMTP id fv9so231567365pac.3
	for <qemu-devel@nongnu.org>; Tue, 27 Oct 2015 05:28:45 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <013901d110b0$98f81a20$cae84e60$@samsung.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <562F6DF5.3060509@redhat.com>
Date: Tue, 27 Oct 2015 13:28:37 +0100
MIME-Version: 1.0
In-Reply-To: <013901d110b0$98f81a20$cae84e60$@samsung.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while
 setting MPOL_DEFAULT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Cc: 'Eduardo Habkost' <ehabkost@redhat.com>



On 27/10/2015 13:11, Pavel Fedin wrote:
> +            if ((backend->policy != MPOL_DEFAULT) || (errno != ENOSYS)) {

Can you remove parentheses around conditions?

Paolo

> +                error_setg_errno(errp, errno,
>                               "cannot bind memory to host NUMA nodes");
> -            return;
> +                return;