qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>,
	'Eduardo Habkost' <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name property
Date: Tue, 27 Oct 2015 08:37:52 -0600	[thread overview]
Message-ID: <562F8C40.1030707@redhat.com> (raw)
In-Reply-To: <002701d110be$ed01e4d0$c705ae70$@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On 10/27/2015 07:53 AM, Pavel Fedin wrote:
> This option allows to explicitly specify file name to use with the backend.
> This is important when using it together with ivshmem in order to make it
> backed by hugetlbfs. By default filename is autogenerated using mkstemp(),
> and the file is unlink()ed after creation, effectively making it
> anonymous. This is not very useful with ivshmem because it ends up in a
> memory which cannot be accessed by something else.
> 
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> Tested-by: Igor Skalkin <i.skalkin@samsung.com>
> ---
>  backends/hostmem-file.c | 26 +++++++++++++++++++++++++-
>  exec.c                  | 36 ++++++++++++++++++++++++------------
>  include/exec/memory.h   |  3 +++
>  include/exec/ram_addr.h |  2 +-
>  memory.c                |  4 +++-
>  numa.c                  |  2 +-
>  qemu-doc.texi           |  2 +-
>  7 files changed, 58 insertions(+), 17 deletions(-)

Is there a missing qapi change, so that the new filename attribute can
also be specified by QMP command?  Or do we not support hotplug of
ivshmem yet?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-10-27 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 13:53 [Qemu-devel] [PATCH] backends/hostmem-file: Add file-name property Pavel Fedin
2015-10-27 14:37 ` Eric Blake [this message]
2015-10-27 14:51   ` Pavel Fedin
2015-10-27 14:58 ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562F8C40.1030707@redhat.com \
    --to=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=p.fedin@samsung.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).