From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5tf-0000to-SL for qemu-devel@nongnu.org; Tue, 27 Oct 2015 11:10:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr5ta-00039u-Ti for qemu-devel@nongnu.org; Tue, 27 Oct 2015 11:10:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5ta-00039n-L8 for qemu-devel@nongnu.org; Tue, 27 Oct 2015 11:10:42 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2BAA4C0AF7A3 for ; Tue, 27 Oct 2015 15:10:42 +0000 (UTC) References: <1444921716-9511-1-git-send-email-armbru@redhat.com> <1445957481-21059-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <562F93F1.1060808@redhat.com> Date: Tue, 27 Oct 2015 09:10:41 -0600 MIME-Version: 1.0 In-Reply-To: <1445957481-21059-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cStKOV8d9iPsPLUDtBiWUbogw04vUA92e" Subject: Re: [Qemu-devel] [PATCH 4.5/7] glib: add compatibility interface for g_hash_table_add() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cStKOV8d9iPsPLUDtBiWUbogw04vUA92e Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/27/2015 08:51 AM, Markus Armbruster wrote: > The next commit will use it. >=20 > Signed-off-by: Markus Armbruster > --- > include/glib-compat.h | 7 +++++++ > 1 file changed, 7 insertions(+) One nit: >=20 > diff --git a/include/glib-compat.h b/include/glib-compat.h > index fb25f43..5185630 100644 > --- a/include/glib-compat.h > +++ b/include/glib-compat.h > @@ -165,6 +165,13 @@ static inline GThread *g_thread_new(const char *na= me, > #define CompatGCond GCond > #endif /* glib 2.31 */ > =20 > +#if !GLIB_CHECK_VERSION(2, 32, 0) > +static inline gboolean g_hash_table_add (GHashTable *hash_table, gpoin= ter key) Drop the space before ( Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cStKOV8d9iPsPLUDtBiWUbogw04vUA92e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWL5PxAAoJEKeha0olJ0Nqn9sIAIMpYbfSRjUIQ/tgLGocsFc8 8llAWTDRlhz/fCG1fTSs0++9SU68Z+sKodCvmyqUrNRC5Qr9+HijuZjXr8iQTx8p 8G9Y1rFHDHdYOgruA6nklzcA9Q/30yN6zW/mxm5lq2ErwAPn5CSg/04Ivrvf47K8 ZMTPkjkbSv6P6fcn92TxfQy8k15AIpH741rvhGHfl907zfTCvTaaFB2FmGxNlxQa oCWsFPW5gnyhRHNRBDbe187YyVmX9x9noOL2GVJicZiLud7h7my8l4Cr0lS5IyiN GId4FnQqBMv9dO9zejTVHIFoAT9wa/0yae9ue7rG3cxXEDbbUEd8H9tiApJAYNY= =7U/a -----END PGP SIGNATURE----- --cStKOV8d9iPsPLUDtBiWUbogw04vUA92e--