From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr6nQ-0004WA-6M for qemu-devel@nongnu.org; Tue, 27 Oct 2015 12:08:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr6nP-0002aJ-9o for qemu-devel@nongnu.org; Tue, 27 Oct 2015 12:08:24 -0400 References: <1445903114-22566-1-git-send-email-jsnow@redhat.com> <1445903114-22566-4-git-send-email-jsnow@redhat.com> <562EE0CE.1040401@redhat.com> <562F9D5E.8040809@redhat.com> From: Eric Blake Message-ID: <562FA14C.4030002@redhat.com> Date: Tue, 27 Oct 2015 10:07:40 -0600 MIME-Version: 1.0 In-Reply-To: <562F9D5E.8040809@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i0Rn6vK2E2IMrlgADL4fea2SMipboPDLQ" Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i0Rn6vK2E2IMrlgADL4fea2SMipboPDLQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/27/2015 09:50 AM, John Snow wrote: >>> + default: >>> + printf("Parsing error -- %s\n", arg); >> >> I still think ':' is better than ' --' in error messages, but I'll lea= ve >> it up to the maintainer. >> >=20 > Crud, sorry Eric -- I didn't do this on purpose. As Kevin notes, I was > just trying to match the existing format. I can change it and send agai= n > if you want. Whatever is easiest for people. And Kevin has a valid point that you just did code motion, so keeping -- is no worse than before. At this point, I'll leave it up to you; my R-b stands either way. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --i0Rn6vK2E2IMrlgADL4fea2SMipboPDLQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWL6FMAAoJEKeha0olJ0NqM6cIAJ+erAAz8yOFMZckn+NKyXxw 9tk2aP9RmYO8KdraM+YwZl/sHEEVYK8tlLGuyahak8iY6SSJ5QObv640n5hYG+R1 KjmWFlSgWDhqbohVyrQ0S1BlaGfDZLO2w4L5/1cav0z/yOxJ0dUi++zSeqEhn5N8 78afWzYJQhiDg5u4hsgwSowi82HRYMYp9jzELmaeoauYwDMEG4lEU1FR2Krt+mqh 3uDiDbQe3Esp0fhF3KpQKdFw1di5eIMp4OfSoehy81UejjuZBUk5nRhcZ74D6GH4 HQ+hhj+vT22dbAwBDyS9h3X6xKX0eQvRzlMIAbxO8llgeW5bvSRGU3/KX5jyP1w= =lttg -----END PGP SIGNATURE----- --i0Rn6vK2E2IMrlgADL4fea2SMipboPDLQ--