From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr8gd-0002og-3a for qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr8gZ-0004oT-2G for qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:09:31 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=53389 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr8gY-0004oO-SG for qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:09:26 -0400 Message-ID: <562FBDC2.9050700@weilnetz.de> Date: Tue, 27 Oct 2015 19:09:06 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1440832355-4933-1-git-send-email-sw@weilnetz.de> <5605A507.7080200@weilnetz.de> In-Reply-To: <5605A507.7080200@weilnetz.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: QEMU Developer Am 25.09.2015 um 21:48 schrieb Stefan Weil: > Am 29.08.2015 um 09:12 schrieb Stefan Weil: >> Casting pointers to long won't work on 64 bit Windows. >> It is not needed with the right format strings. >> >> Signed-off-by: Stefan Weil >> --- >> slirp/bootp.c | 12 +++++++++--- >> slirp/if.c | 4 ++-- >> slirp/ip_icmp.c | 4 ++-- >> slirp/ip_input.c | 10 +++++----- >> slirp/ip_output.c | 4 ++-- >> slirp/mbuf.c | 6 +++--- >> slirp/misc.c | 6 +++--- >> slirp/sbuf.c | 4 ++-- >> slirp/socket.c | 18 +++++++++--------- >> slirp/tcp_input.c | 14 +++++++------- >> slirp/tcp_output.c | 2 +- >> slirp/tcp_subr.c | 16 ++++++++-------- >> slirp/udp.c | 6 +++--- >> 13 files changed, 56 insertions(+), 50 deletions(-) >> > Ping? Should I add this patch to my pull queue for Windows? > I am afraid that it is too large for qemu-trivial. > > Regards, > Stefan > > http://patchwork.ozlabs.org/patch/512116/ Ping?