From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr8lY-0005i8-70 for qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr8lU-0005rr-BG for qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:14:36 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=53450 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr8lU-0005rm-4j for qemu-devel@nongnu.org; Tue, 27 Oct 2015 14:14:32 -0400 Message-ID: <562FBEFD.2010206@weilnetz.de> Date: Tue, 27 Oct 2015 19:14:21 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1445968123-1773-1-git-send-email-den@openvz.org> <1445968123-1773-3-git-send-email-den@openvz.org> In-Reply-To: <1445968123-1773-3-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IMn3GHt17OrrvUG1pxs0bnIVWKc2ReWl8" Subject: Re: [Qemu-devel] [PATCH 2/3] qga: fixed CloseHandle in qmp_guest_file_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Olga Krishtal , qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IMn3GHt17OrrvUG1pxs0bnIVWKc2ReWl8 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Am 27.10.2015 um 18:48 schrieb Denis V. Lunev: > From: Olga Krishtal >=20 > CloseHandle use HANDLE as an argument, but not *HANDLE >=20 > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Michael Roth > CC: Stefan Weil > --- > qga/commands-win32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index d9de23b..97f19d5 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -160,7 +160,7 @@ int64_t qmp_guest_file_open(const char *path, bool = has_mode, > =20 > fd =3D guest_file_handle_add(fh, errp); > if (fd < 0) { > - CloseHandle(&fh); > + CloseHandle(fh); > error_setg(errp, "failed to add handle to qmp handle table"); > return -1; > } >=20 Reviewed-by: Stefan Weil --IMn3GHt17OrrvUG1pxs0bnIVWKc2ReWl8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJWL78EAAoJEOCMIdVndFCtCkwP/3jspTtj6gre3SjzfwrJWp8+ UlC2WwuqNome8VvLhkWDkM/7aXi2mIoFzdXB/CF30/N0slJuZQE9RqyXvQIR5QqJ xJ3a1DNlhUR+mnNj9p01g/QidoM/ob0sxrBLbJrdT+/RyPxwDGuv9JnUExo8woh0 bO5ovUA0uIkV1Xo43hcC4p1/fTFFG/SpGxwIMORNRqEhXZRcqt3ZAODNNxYQ4Sec IXl6wJsS+Z+U9FiIrksU+xG9qgmDgjky3kByWefhIn39UEGiWwwObSZegKri9+ay ghmZeEIpWZo+PS9EvukXw8p5v1aQkF6W6lwKXUtLV6Leml9HXIkvx8qvmKfX/a+v DAZx+mOgll/yT/EBDb09qWbdgrOYHXfG6HXMaZ5zXyEUJGb/4xpuj+x7kFKF3270 0c+T9t37oJmOqY1rY+zwWrRu7BHULtGbXdfaiaX10KB0fPBmXkt7si1Vad4qe5Qp GIHd0P0LkVw4ZO1JrunZJ4oMNEgys8xL28HKjsfBRjyuSDPMhol+gLimV+rkKrGF zo93gXxP5sZg5hMbhvDTR7u4L9nkTTtrgbQ9xwrQ2nb0gKZfVotX/WVVcBHmiGXv 0n4h9bmGlpWsuxdqlRNgjzDulhBDnW+0C7YXx27cEyIYCFzGSFmtskzMivm7tz35 OCw5RlKqFG5NvWI1xrgt =oK8T -----END PGP SIGNATURE----- --IMn3GHt17OrrvUG1pxs0bnIVWKc2ReWl8--