From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45452)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZrA2Y-0005s5-Ib
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 15:36:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZrA2V-0004Y4-CK
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 15:36:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56696)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZrA2V-0004Xu-7Q
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 15:36:11 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 6B312AACEE
	for <qemu-devel@nongnu.org>; Tue, 27 Oct 2015 19:36:10 +0000 (UTC)
References: <1445879623-8403-1-git-send-email-ehabkost@redhat.com>
	<20151027073038.GA3927@hawk.localdomain>
	<20151027192546.GK4180@thinpad.lan.raisama.net>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <562FD227.40607@redhat.com>
Date: Tue, 27 Oct 2015 20:36:07 +0100
MIME-Version: 1.0
In-Reply-To: <20151027192546.GK4180@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with
 error_report()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 10/27/15 20:25, Eduardo Habkost wrote:
> On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote:
>> In addition to Markus' and Eric's comments, I think we should
>>
>> 1. make sure the first word's case is correct. Lowercase for phrases,
>>    uppercase for sentences and proper nouns.
> 
> I think I can understand this in the more obvious cases, but I don't
> know how I could convert the following instance:
> 
> [...]
>>>              case QEMU_OPTION_no_kvm_pit: {
>>> -                fprintf(stderr, "Warning: KVM PIT can no longer be disabled "
>>> -                                "separately.\n");
>>> +                error_report("Warning: KVM PIT can no longer be disabled "
>>> +                             "separately.");
>>
>> Could change this from a sentence into a phrase. Also, we need a consistent
>> 'warning' prefix. Should we make a error_report_warn variant?
> 
> Converting that sentence to a phrase is beyond my non-native english
> speaker skills. Do you have any suggestions? :)
> 

easy-peasy, "KVM PIT no longer disableable separately"!

/me hides ;)