From: Jason Wang <jasowang@redhat.com>
To: Leonid Bloch <leonid.bloch@ravellosystems.com>, qemu-devel@nongnu.org
Cc: Dmitry Fleytman <dmitry@daynix.com>,
Leonid Bloch <leonid@daynix.com>,
Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation
Date: Wed, 28 Oct 2015 13:41:20 +0800 [thread overview]
Message-ID: <56306000.30009@redhat.com> (raw)
In-Reply-To: <1445952027-28541-1-git-send-email-leonid.bloch@ravellosystems.com>
On 10/27/2015 09:20 PM, Leonid Bloch wrote:
> This series fixes issues with packet/octet counting in e1000's Statistic
> registers, fixes a bug in the packet address filtering procedure, and
> implements many MAC registers that were absent before, some Statistic
> counters among them. Additionally, several cosmetic changes are made.
>
> Differences from v1:
> --------------------
> * Wording of several commit messages corrected.
> * For trivially implemented Diagnostic registers, a debug message is
> added on read/write attempts, alerting of incomplete implementation.
> * Following testing on a physical device, only the lower 16 bits can now
> be read from AIT, and only the lower 4 - from FFMT*.
> * The grow_8reg_if_not_full function is rewritten.
> * inc_tx_bcast_or_mcast_count and increase_size_stats are now called
> from within e1000_send_packet, to avoid code duplication.
>
> The majority of these changes result from Jason Wang's review - thank
> you, Jason!
>
> Leonid Bloch (6):
> e1000: Cosmetic and alignment fixes
> e1000: Trivial implementation of various MAC registers
> e1000: Fixing the received/transmitted packets' counters
> e1000: Fixing the received/transmitted octets' counters
> e1000: Fixing the packet address filtering procedure
> e1000: Implementing various counters
>
> hw/net/e1000.c | 352 +++++++++++++++++++++++++++++++++++++++-------------
> hw/net/e1000_regs.h | 8 +-
> 2 files changed, 275 insertions(+), 85 deletions(-)
>
Applied in https://github.com/jasowang/qemu/commits/net
Thanks
next prev parent reply other threads:[~2015-10-28 5:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 13:20 [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation Leonid Bloch
2015-10-27 13:20 ` [Qemu-devel] [PATCH v2 1/6] e1000: Cosmetic and alignment fixes Leonid Bloch
2015-10-27 13:20 ` [Qemu-devel] [PATCH v2 3/6] e1000: Fixing the received/transmitted packets' counters Leonid Bloch
2015-10-27 13:20 ` [Qemu-devel] [PATCH v2 4/6] e1000: Fixing the received/transmitted octets' counters Leonid Bloch
2015-10-27 13:20 ` [Qemu-devel] [PATCH v2 5/6] e1000: Fixing the packet address filtering procedure Leonid Bloch
2015-10-27 13:20 ` [Qemu-devel] [PATCH v2 6/6] e1000: Implementing various counters Leonid Bloch
2015-10-28 5:41 ` Jason Wang [this message]
2015-10-28 6:17 ` [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation Dmitry Fleytman
2015-10-28 6:20 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56306000.30009@redhat.com \
--to=jasowang@redhat.com \
--cc=dmitry@daynix.com \
--cc=leonid.bloch@ravellosystems.com \
--cc=leonid@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=shmulik.ladkani@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).