From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrSac-0003kU-IH for qemu-devel@nongnu.org; Wed, 28 Oct 2015 11:24:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrSaY-00022P-7Z for qemu-devel@nongnu.org; Wed, 28 Oct 2015 11:24:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrSaY-00022L-1a for qemu-devel@nongnu.org; Wed, 28 Oct 2015 11:24:34 -0400 References: <1446020161-21758-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5630E8AC.4000900@redhat.com> Date: Wed, 28 Oct 2015 09:24:28 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U2xmHxhGkQ18q6uWHVU6SaILn06vfgt3T" Subject: Re: [Qemu-devel] [PULL v2 00/14] QMP and QObject patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Markus Armbruster Cc: QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U2xmHxhGkQ18q6uWHVU6SaILn06vfgt3T Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/28/2015 09:07 AM, Peter Maydell wrote: >> glib: add compatibility interface for g_hash_table_add() >> monitor: Turn monitor_qapi_event_state[] into a hash table >=20 > CC qga/commands-posix.o > In file included from /Users/pm215/src/qemu-for-merges/qga/main.c:25: > In file included from > /Users/pm215/src/qemu-for-merges/include/qapi/qmp/json-parser.h:17: > In file included from /Users/pm215/src/qemu-for-merges/include/qemu-com= mon.h:25: > /Users/pm215/src/qemu-for-merges/include/glib-compat.h:171:12: error: > returning 'void' from a function with incompatible result type > 'gboolean' (aka 'int') > return g_hash_table_replace(hash_table, key, key) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > Looks like g_hash_table_replace was originally a 'void' return > and switched to 'gboolean' return at some later date: >=20 > https://github.com/GNOME/glib/commit/910191597a6c2e5d5d460e9ce9efb4f47d= 9cc63c This patch series isn't using the return value of g_hash_table_add, so our glib replacement could be changed to return void. On the other hand, would it be better to proactively retrofit the return type into ALL of the g_hash_table_* functions that were swapped to return a value, so that future uses of the functions with qemu can make use of the modern contract, even though this series doesn't use it? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --U2xmHxhGkQ18q6uWHVU6SaILn06vfgt3T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWMOisAAoJEKeha0olJ0Nqu+gH/2RO/k8cBray3rJLEfmBiAS0 yh+mJnzMNen8DthNnBN7y8pSVtTA7TfmMPMO6mv6A2WjwQ8LUIORwGOrpCK5Ynzl 0g2t3hCOpFD/PcbPd+EwkZ8rafsj20dbgETjJpvfAzdRHyLLddOea5tQea7XsGx4 mu/yn4Z6QDhO/LmTX76nFs44kaNN+pDWFvSoF5C69/2w0GVGxBQ+ifU/xz0Q1H55 McxPtQhZh5DZAy30vjqwtBLA4LXgEveL+98sh2NOrbT0dk4uSz8+2zuECKe+J5g9 fMs+6MzWx7rhxOGo+36fBRe5SftOW/ucU/5JEOAbHzpN8VAZyBcFPdMgtwpB+hk= =6kTD -----END PGP SIGNATURE----- --U2xmHxhGkQ18q6uWHVU6SaILn06vfgt3T--