From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrSdk-00050k-Rt for qemu-devel@nongnu.org; Wed, 28 Oct 2015 11:27:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrSdf-0002eo-Si for qemu-devel@nongnu.org; Wed, 28 Oct 2015 11:27:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrSdf-0002ei-N7 for qemu-devel@nongnu.org; Wed, 28 Oct 2015 11:27:47 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 6641C341ACC for ; Wed, 28 Oct 2015 15:27:47 +0000 (UTC) References: <1445879623-8403-1-git-send-email-ehabkost@redhat.com> <20151027073038.GA3927@hawk.localdomain> <20151027192546.GK4180@thinpad.lan.raisama.net> <562FD227.40607@redhat.com> <20151028135800.GB5861@hawk.localdomain> From: Laszlo Ersek Message-ID: <5630E96E.9010407@redhat.com> Date: Wed, 28 Oct 2015 16:27:42 +0100 MIME-Version: 1.0 In-Reply-To: <20151028135800.GB5861@hawk.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: Paolo Bonzini , Eduardo Habkost , Markus Armbruster , qemu-devel@nongnu.org On 10/28/15 14:58, Andrew Jones wrote: > On Tue, Oct 27, 2015 at 08:36:07PM +0100, Laszlo Ersek wrote: >> On 10/27/15 20:25, Eduardo Habkost wrote: >>> On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: >>>> In addition to Markus' and Eric's comments, I think we should >>>> >>>> 1. make sure the first word's case is correct. Lowercase for phrases, >>>> uppercase for sentences and proper nouns. >>> >>> I think I can understand this in the more obvious cases, but I don't >>> know how I could convert the following instance: >>> >>> [...] >>>>> case QEMU_OPTION_no_kvm_pit: { >>>>> - fprintf(stderr, "Warning: KVM PIT can no longer be disabled " >>>>> - "separately.\n"); >>>>> + error_report("Warning: KVM PIT can no longer be disabled " >>>>> + "separately."); >>>> >>>> Could change this from a sentence into a phrase. Also, we need a consistent >>>> 'warning' prefix. Should we make a error_report_warn variant? >>> >>> Converting that sentence to a phrase is beyond my non-native english >>> speaker skills. Do you have any suggestions? :) >>> >> >> easy-peasy, "KVM PIT no longer disableable separately"! >> >> /me hides ;) > As well you should with a word like "disableable" :-) > > How about > > Warning: ignoring deprecated option no-kvm-pit heh, side-stepping the problem semantically; that's a trick I'll steal! :) > > drew > >>