From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZroER-0002r5-CY for qemu-devel@nongnu.org; Thu, 29 Oct 2015 10:31:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZroEM-0000y4-EE for qemu-devel@nongnu.org; Thu, 29 Oct 2015 10:31:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZroEM-0000xt-9K for qemu-devel@nongnu.org; Thu, 29 Oct 2015 10:31:06 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C58AEA58B4 for ; Thu, 29 Oct 2015 14:31:05 +0000 (UTC) References: <1446117309-15322-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56322DA4.3070702@redhat.com> Date: Thu, 29 Oct 2015 08:31:00 -0600 MIME-Version: 1.0 In-Reply-To: <1446117309-15322-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o5qeuBqVQx41rq3Ro1txbFlsohJ9Qk02m" Subject: Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --o5qeuBqVQx41rq3Ro1txbFlsohJ9Qk02m Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/29/2015 05:15 AM, Markus Armbruster wrote: > Leak introduced in commit 8a4f501..710aec9, v2.4.0. >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/monitor.c b/monitor.c > index 301a143..c59e85b 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser = *parser, QList *tokens) > err_out: > monitor_protocol_emitter(mon, data, local_err); > qobject_decref(data); > + error_free(local_err); > QDECREF(input); > QDECREF(args); > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --o5qeuBqVQx41rq3Ro1txbFlsohJ9Qk02m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWMi2oAAoJEKeha0olJ0Nq8jQH/i/ZuRg9Jw9XmZU/JcEIxcyq S2e5XvKuAdOLKZxkAZ9xF7HzH3lDcZf7iKyw/4fXKkefdQfXcH9Naogdjc0r3H3r nWkGkynNwh9fRuISum1d0OF0gxB5hXk6pjoj/wQYDVdJ3OP33IWDHgIki2AnvhlW U25eyBNcq2ycv31WMAAA+aaWNsCIY9d5ISVYrNauLQ4678GH54zpN1oT9F6au6AA N8U4BltmtKucKjJmYMC3H/bbhN/5OdFJHNErKK8DdpOr5jd4IkStoYJQPWQUqfth gbAn9BV+iCLSIJLnwkssFEsr0xZLgxygo6jCkLEZW5ge/BQuk/wrRpYZknHlb2E= =7B3R -----END PGP SIGNATURE----- --o5qeuBqVQx41rq3Ro1txbFlsohJ9Qk02m--