qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] configure: disallow ccache during compile tests
Date: Thu, 29 Oct 2015 11:53:17 -0400	[thread overview]
Message-ID: <563240ED.2080700@redhat.com> (raw)
In-Reply-To: <87611q8agw.fsf@blackfin.pond.sub.org>



On 10/29/2015 02:17 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
> 
>> If the user is using CCACHE during the configuration step,
>> it may interfere with some of the configuration tests,
>> particularly the "Is CCACHE interfering with macro analysis" step,
>> which is a bit of a poetic problem.
>>
>> 1) Disallow CCACHE from reading from the cache during configure,
>>    but don't disable it to allow us to see if it causes other problems.
> 
> This is confusing.  "don't disable it entirely"?
> 

We allow it to submit items into the cache, but not to read items from
the cache. This prevents it from picking up cached results to the
compile tests.

I don't disable it entirely (just pass-through to the real compiler
without using ccache at all) because I still want to allow ccache to be
processing things to test for ccache failures -- particularly the ccache
macro check that occurs later.

If I just disable ccache, that later check is meaningless. Setting the
cache to "write only" gives me the best of both worlds.

>> 2) Force off CCACHE_CPP2 during the ccache test to get a deterministic
>>    answer over whether or not we need to enable that feature later.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>

  reply	other threads:[~2015-10-29 15:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 17:56 [Qemu-devel] [PATCH] configure: disallow ccache during compile tests John Snow
2015-10-29  6:17 ` Markus Armbruster
2015-10-29 15:53   ` John Snow [this message]
2015-10-29 16:22     ` Markus Armbruster
2015-11-02 14:54       ` Paolo Bonzini
2015-11-02 14:57 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563240ED.2080700@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).