From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrrNd-0001lr-TB for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:52:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrrNZ-00061u-PK for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:52:53 -0400 Received: from relay.parallels.com ([195.214.232.42]:44997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrrNZ-00061h-8b for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:52:49 -0400 References: <1445850626-29407-1-git-send-email-den@openvz.org> <1445850626-29407-4-git-send-email-den@openvz.org> <20151029172318.GH5466@stefanha-x1.localdomain> From: "Denis V. Lunev" Message-ID: <56325CE2.8070705@openvz.org> Date: Thu, 29 Oct 2015 20:52:34 +0300 MIME-Version: 1.0 In-Reply-To: <20151029172318.GH5466@stefanha-x1.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: peter.maydell@linaro.org, pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 10/29/2015 08:23 PM, Stefan Hajnoczi wrote: > On Mon, Oct 26, 2015 at 12:10:20PM +0300, Denis V. Lunev wrote: >> From: Paolo Bonzini >> >> This is cleaner, and improves error reporting with -daemonize. >> >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Denis V. Lunev >> Reviewed-by: Christian Borntraeger >> --- >> qemu-io.c | 2 +- >> trace/control.c | 17 ++++++++++++----- >> trace/control.h | 13 ++++++++++++- >> trace/simple.c | 6 ++---- >> trace/simple.h | 4 ++-- >> vl.c | 13 +++++++++---- >> 6 files changed, 38 insertions(+), 17 deletions(-) >> >> diff --git a/qemu-io.c b/qemu-io.c >> index 269f17c..fbddf82 100644 >> --- a/qemu-io.c >> +++ b/qemu-io.c >> @@ -440,7 +440,7 @@ int main(int argc, char **argv) >> } >> break; >> case 'T': >> - if (!trace_init_backends(optarg, NULL)) { >> + if (!trace_init_backends()) { > The previous patch dropped the 2nd argument to trace_init_backends(). I > guess that means the previous patch doesn't compile by itself? > > Please move this hunk to the previous patch so that git-bisect(1) works > (i.e. each commit builds successfully and runs). yes, you are right. I have mistaken fixing Paolo's patchset. This needs to be addressed. I'll do this in a couple of hours when I'll be at home. Den