From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches
Date: Thu, 29 Oct 2015 13:10:51 -0600 [thread overview]
Message-ID: <56326F3B.60802@redhat.com> (raw)
In-Reply-To: <877fm5sewy.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On 10/29/2015 12:33 PM, Markus Armbruster wrote:
>> Still doesn't build with old glib:
>>
>> In file included from /Users/pm215/src/qemu-for-merges/qga/commands.c:14:
>> In file included from
>> /Users/pm215/src/qemu-for-merges/qga/guest-agent-core.h:14:
>> In file included from /Users/pm215/src/qemu-for-merges/include/qemu-common.h:25:
>> /Users/pm215/src/qemu-for-merges/include/glib-compat.h:172:47: error:
>> expected ';' after expression
>> g_hash_table_replace(hash_table, key, key)
>> ^
>> ;
>>
>> I did a trial build with the typo fixed, and that is OK, so this
>> should be the last fix required, I think.
>
> Hand me the brown paper bag...
And me, for letting that slip by review even when I caught 'add (' on
the line above.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-29 19:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 14:32 [Qemu-devel] [PULL v3 00/14] QMP and QObject patches Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 01/14] qobject: Drop QObject_HEAD Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 02/14] qbool: Make conversion from QObject * accept null Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 03/14] qdict: " Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 04/14] qfloat qint: " Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 05/14] qlist: " Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 06/14] qstring: " Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 07/14] monitor: Reduce casting of QAPI event QDict Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 08/14] monitor: Simplify event throttling Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 09/14] monitor: Switch from timer_new() to timer_new_ns() Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 10/14] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 11/14] glib: add compatibility interface for g_hash_table_add() Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 12/14] monitor: Turn monitor_qapi_event_state[] into a hash table Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 13/14] monitor: Throttle event VSERPORT_CHANGE separately by "id" Markus Armbruster
2015-10-29 14:32 ` [Qemu-devel] [PULL v3 14/14] docs: Document QMP event rate limiting Markus Armbruster
2015-10-29 17:27 ` [Qemu-devel] [PULL v3 00/14] QMP and QObject patches Peter Maydell
2015-10-29 18:33 ` Markus Armbruster
2015-10-29 19:10 ` Eric Blake [this message]
2015-10-30 8:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56326F3B.60802@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).