From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsBVh-000626-Rb for qemu-devel@nongnu.org; Fri, 30 Oct 2015 11:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsBVc-0007w0-W3 for qemu-devel@nongnu.org; Fri, 30 Oct 2015 11:22:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsBVc-0007vw-Py for qemu-devel@nongnu.org; Fri, 30 Oct 2015 11:22:28 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6C757FA9D1 for ; Fri, 30 Oct 2015 15:22:28 +0000 (UTC) References: <1446122683-2355-1-git-send-email-armbru@redhat.com> <1446122683-2355-5-git-send-email-armbru@redhat.com> <56324CB8.5060303@redhat.com> <87io5psf7m.fsf@blackfin.pond.sub.org> <5632AD4A.8040504@redhat.com> <87bnbgpzcw.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56338B2E.50004@redhat.com> Date: Fri, 30 Oct 2015 09:22:22 -0600 MIME-Version: 1.0 In-Reply-To: <87bnbgpzcw.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4lGKQQQj2pPom2OxCXR66cm5jbq9qmAGf" Subject: Re: [Qemu-devel] [PATCH 4/4] json-streamer: Limit number of tokens in addition to total size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4lGKQQQj2pPom2OxCXR66cm5jbq9qmAGf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/30/2015 01:52 AM, Markus Armbruster wrote: >>>> I'm assuming you temporarily patched check-qjson to use larger const= ants >>>> when you hit your ~100K token testing? Because I am definitely seei= ng a >>>> lot of execution time spent on large_dict when running tests/check-q= json >>>> by hand, in relation to all the other tests of that file, but not >>>> minutes worth. Care to post the diff you played with? >>> >>> I tested on a slow machine. >> >> I guess it was all the malloc pressure on a low-memory system that wou= ld >> make it so much slower than what I'm seeing, if you stuck with the >> default gen_test_json(gstr, 10, 100). >=20 > Something must have been wrong with this machine yesterday, because > today it runs the exact same test much, much faster. Computers... Or maybe you had still reverted 65c0f1e9 to figure out where the regression was at asserting rather than gracefully failing as fixed by patch 2/4? Still, even if it is much faster, it is noticeably slow enough to wonder if we have some inefficiencies beyond the poor memory usage. >=20 > I'll update the commit message. Thanks for your sanity check! >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4lGKQQQj2pPom2OxCXR66cm5jbq9qmAGf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWM4suAAoJEKeha0olJ0NqxsYH/j3cIyAnXWBrHnhPVrn9zW9g qv2NT3jBK0ziOGBy73JzZ6mgdQCMxYM60WTeKwkil4Irg8tBOPWa0HO7kmvsSJhh FYLi151MhETlyazwKXT8goeDhIRhl+LYSiAFnlQ0gBrHpYQFJSulUE3Fz9Cgmv0P h/yPIVpuj6xnAGUkX6maBYefVnkVprTHYj06WccgWFuZ3i1aJM0VpxVXppTuTL0s rfrm2q6QNTio9eMrufdf3pCO5VxDLn47EruBdyZrKgYlOSjZg6iTv8MlwKAySL7O FFuuSNKfm1AAaekMB80EE0XL83C7/p0E0DGGZIY/2W0qVLcI+Zr2Bn6iCi0RHNQ= =YHqT -----END PGP SIGNATURE----- --4lGKQQQj2pPom2OxCXR66cm5jbq9qmAGf--