From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsD8F-0002uL-HV for qemu-devel@nongnu.org; Fri, 30 Oct 2015 13:06:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsD8C-0004Z1-BD for qemu-devel@nongnu.org; Fri, 30 Oct 2015 13:06:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsD8C-0004Ym-3c for qemu-devel@nongnu.org; Fri, 30 Oct 2015 13:06:24 -0400 References: <1446184587-142784-1-git-send-email-guangrong.xiao@linux.intel.com> <1446184587-142784-15-git-send-email-guangrong.xiao@linux.intel.com> From: Eric Blake Message-ID: <5633A388.9020404@redhat.com> Date: Fri, 30 Oct 2015 11:06:16 -0600 MIME-Version: 1.0 In-Reply-To: <1446184587-142784-15-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xEHPG3hCeGIjxWRm12PjcTj1HvFkV1egX" Subject: Re: [Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong , pbonzini@redhat.com, imammedo@redhat.com Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xEHPG3hCeGIjxWRm12PjcTj1HvFkV1egX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/29/2015 11:56 PM, Xiao Guangrong wrote: > This patch is generated by this script: >=20 > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type = f \ > | xargs sed -i "s/PC_DIMM/DIMM/g" >=20 > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type = f \ > | xargs sed -i "s/PCDIMM/DIMM/g" >=20 > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type = f \ > | xargs sed -i "s/pc_dimm/dimm/g" The '-type f' binds only to the '-name trace-events' clause, and not the 'name "*.[ch]"' or '-name "*.json"', but since we don't have any directories by those names, it didn't matter. You probably could have eliminated the -type f with no consequences, rather than adding "(" and ")". In fact, you could have used git rather than find to do it: git grep -il 'pc_\?dimm' | xargs ... which finds only one additional instance of pc_dimm in stubs/Makefile.objs - so maybe you should: git mv stubs/qmp_{pc_,}dimm_device_list.c either in this patch or as a followup. Could compress these three sed lines into one, if desired: find ... | xargs sed -i 's/pc_\?\(dimm\)/\1/ig' But doesn't really matter. I'm fine if you leave your commit message as-is, and will let you decide what to do about the stub file name. >=20 > find ./ -name "trace-events" -type f | xargs sed -i "s/pc-dimm/dimm/g" >=20 > It prepares the work which abstracts dimm device type for both pc-dimm = and > nvdimm >=20 > Signed-off-by: Xiao Guangrong > --- Reviewed-by: Eric Blake > qapi-schema.json | 8 +-- Touches public interface files, but does not affect ABI, so it is safe. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xEHPG3hCeGIjxWRm12PjcTj1HvFkV1egX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWM6OIAAoJEKeha0olJ0Nq/vsH/iTGda+Q/m2Nb8AcD6LRtdw6 FppSQ7O6ZXkfgSo3+oUQKG6pNq/9Ja/FREqzOgqb9z3DichRRz55VEmLwzRj26Nj AQx2WHGnno7Z4rzCtwxWz/Aam/j3Zqz2yX0Z1CSHEfQ+g+gau84mMGYvhO4W12O4 k1oEszJcsFl+cQzMtRONtgAb9A3Gp3eMXR15kUrhFJNLwOp762uy2qY2b0pAmcfU aKaijEdtgBGc57jKSAD0+tXg+ndmUQAYMlHwR4IBtRYMjitl9V6kbvX42/R8hKSy Y5XDPL9o4MLm3PSJdttikZ4cVHXIePkPX5kDAdZD001VhattWqX70U20NRTgMdo= =bInR -----END PGP SIGNATURE----- --xEHPG3hCeGIjxWRm12PjcTj1HvFkV1egX--