From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-stable@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test the reopening of overlay_bs in 'block-commit'
Date: Fri, 30 Oct 2015 20:19:58 +0100 [thread overview]
Message-ID: <5633C2DE.7080103@redhat.com> (raw)
In-Reply-To: <5cafa09cd82d2ea2c32d741f56b481ac1ae986ac.1446039123.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On 28.10.2015 14:43, Alberto Garcia wrote:
> The 'block-commit' command needs the overlay image of 'top' to
> be opened in read-write mode in order to update the backing file
> string. If 'top' is not the active layer or its backing file then its
> overlay needs to be reopened during the block job.
>
> This is a test case for that scenario.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> tests/qemu-iotests/040 | 30 ++++++++++++++++++++++++++++++
> tests/qemu-iotests/040.out | 4 ++--
> 2 files changed, 32 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-30 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 13:43 [Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit' Alberto Garcia
2015-10-28 13:43 ` [Qemu-devel] [PATCH 1/2] commit: reopen overlay_bs before base Alberto Garcia
2015-10-30 19:14 ` Max Reitz
2015-10-28 13:43 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Test the reopening of overlay_bs in 'block-commit' Alberto Garcia
2015-10-30 19:19 ` Max Reitz [this message]
2015-11-03 12:11 ` [Qemu-devel] [PATCH 0/2] Fix the reopening of images " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5633C2DE.7080103@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).