From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsFu8-0005wC-Fv for qemu-devel@nongnu.org; Fri, 30 Oct 2015 16:04:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsFu4-00019B-Eo for qemu-devel@nongnu.org; Fri, 30 Oct 2015 16:04:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsFu4-000197-9j for qemu-devel@nongnu.org; Fri, 30 Oct 2015 16:04:00 -0400 References: <1446219774-1802-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5633CD2B.1030806@redhat.com> Date: Fri, 30 Oct 2015 14:03:55 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SR8THxmiT071WELK7S6wPtwfl1NLWsBsg" Subject: Re: [Qemu-devel] [PULL 00/25] QAPI patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Markus Armbruster Cc: QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SR8THxmiT071WELK7S6wPtwfl1NLWsBsg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/30/2015 01:47 PM, Peter Maydell wrote: > On 30 October 2015 at 15:42, Markus Armbruster wrot= e: >> char: Convert to new qapi union layout > Hi; I'm afraid this doesn't build on w32: >=20 > /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function > =E2=80=98qmp_chardev_open_file=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4051: error: > =E2=80=98ChardevBackend=E2=80=99 has no member named =E2=80=98file=E2=80= =99 > /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function > =E2=80=98qmp_chardev_open_serial=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4073: error: > =E2=80=98ChardevBackend=E2=80=99 has no member named =E2=80=98serial=E2= =80=99 I'm not set up for easily cross-compiling qemu to windows at the moment, which is why I missed it. But the fix is easy (sent separately). Hopefully that's the only #ifdef spot of code I missed, and we aren't going to play the "whack-a-mole" game of seeing what fails to compile on the next platform after my w32 fixup is squashed in. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SR8THxmiT071WELK7S6wPtwfl1NLWsBsg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWM80rAAoJEKeha0olJ0Nqr7sH/i6VO2gVqQn3plp13B5Etf1g takkY9Sx4xqpezOVssPWh+LxzqTmgcevUF4KKpjiN+zQs8K5YGbiqGEtPXbd6oZr Sq7cdzkGE6r0kiqXkvGQaWSVQPegnvZVj/+/E4HHrLGq3s4WmDXSOp1fukTasztY dY9HtpUTBwqDuBtGLml/05Aj6MWirwG+MaFz6oD6uAmYkQQ0fdfrh5sBllAgME4x TSSQYAG7noCUTEZPWXRk4Y8p8gB+SzgilNh1SprSJkqqQAlr9/zXprraGQtbJFVL E65nJeF/dR6SYk6QWpqr07icf0hFuburNq1ksnEwu4Tp3szJh/k0R+Syio36b/o= =sCMl -----END PGP SIGNATURE----- --SR8THxmiT071WELK7S6wPtwfl1NLWsBsg--