From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsGh8-0001RP-OL for qemu-devel@nongnu.org; Fri, 30 Oct 2015 16:54:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsGh4-00072V-L2 for qemu-devel@nongnu.org; Fri, 30 Oct 2015 16:54:42 -0400 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:36590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsGh4-00072R-Gp for qemu-devel@nongnu.org; Fri, 30 Oct 2015 16:54:38 -0400 Received: by qkcl124 with SMTP id l124so32638720qkc.3 for ; Fri, 30 Oct 2015 13:54:38 -0700 (PDT) Sender: Richard Henderson References: <1446103899-8644-1-git-send-email-guangrong.xiao@linux.intel.com> From: Richard Henderson Message-ID: <5633D909.3030901@twiddle.net> Date: Fri, 30 Oct 2015 13:54:33 -0700 MIME-Version: 1.0 In-Reply-To: <1446103899-8644-1-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong , pbonzini@redhat.com Cc: ehabkost@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On 10/29/2015 12:31 AM, Xiao Guangrong wrote: > These instructions are used by NVDIMM drivers and the specification > locates at: > https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf > > There instructions are available on Skylake Server > > Signed-off-by: Xiao Guangrong > --- > target-i386/cpu.c | 8 +++++--- > target-i386/cpu.h | 3 +++ > 2 files changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson Although it would be nice to update the comments in translate.c to include the new insns, since they overlap mfence and sfence. At present we only check for SSE enabled when accepting these; I suppose it's easiest to consider it invalid to specify +clwb,-sse? r~