From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1ZsH0q-0002jf-U7
	for qemu-devel@nongnu.org; Fri, 30 Oct 2015 17:15:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1ZsH0q-0003u7-3n
	for qemu-devel@nongnu.org; Fri, 30 Oct 2015 17:15:04 -0400
References: <cover.1446232490.git.jcody@redhat.com>
	<0066fd85d26ca641a1c25135ff2479b7985701cf.1446232490.git.jcody@redhat.com>
From: Max Reitz <mreitz@redhat.com>
Message-ID: <5633DDD0.1020305@redhat.com>
Date: Fri, 30 Oct 2015 22:14:56 +0100
MIME-Version: 1.0
In-Reply-To: <0066fd85d26ca641a1c25135ff2479b7985701cf.1446232490.git.jcody@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="LNtnrlKhBKxbeFwITlh48TDnjsgMkGsun"
Subject: Re: [Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option
	for check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, qemu-block@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--LNtnrlKhBKxbeFwITlh48TDnjsgMkGsun
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 30.10.2015 20:25, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu-io from a bash subshell=
,
> in order to catch segfaults.  This method is incompatible with the
> current valgrind_qemu_io() bash function.
>=20
> Move the valgrind usage into the exec subshell in _qemu_io_wrapper(),
> while making sure the original return value is passed back to the
> caller.
>=20
> Update test output for tests 039, 061, and 137 as it looks for the
> specific subshell command when the process is terminated.
>=20
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  tests/qemu-iotests/039.out       | 30 +++++++++++++++++++++++++-----
>  tests/qemu-iotests/061.out       | 12 ++++++++++--
>  tests/qemu-iotests/137.out       |  6 +++++-
>  tests/qemu-iotests/common        |  9 ++-------
>  tests/qemu-iotests/common.config | 18 +++++++++++++++++-
>  tests/qemu-iotests/common.rc     | 10 ----------
>  6 files changed, 59 insertions(+), 26 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


--LNtnrlKhBKxbeFwITlh48TDnjsgMkGsun
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWM93QAAoJEDuxQgLoOKytvzIH/jnkWgGBZ9h3eGmODbbDRYvY
uSCW3P/cfFOL+LAArS1JUG7peiHPPeg9o7hjo0uU/Zl6Cxc+kbgzKGrT6mBCkHHl
3dyx5tY8Eh2XxcyTIfdWIrGJlZNO6iof/K0ShriupF6Yk+nwNLCkrja2HiltMcwE
3M6V7WyJbcSfxjUcH35bw2zeTJCzb8cIIaA1Azj74nJzA3vbpH+cFlqEdovVwT4a
0ZYZ34i0RInbdw7D0yrlNu4rqSQIF85TLdGJxkcFvSlhRMoX56A737QfGK/3NdeY
zHlIBH6s6LttE4lYBbPqjcdGEbhHvmKUS2miIjbns9yV8sbfsbPG+IYib29dacM=
=7cya
-----END PGP SIGNATURE-----

--LNtnrlKhBKxbeFwITlh48TDnjsgMkGsun--