From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsRaV-0001Lp-R1 for qemu-devel@nongnu.org; Sat, 31 Oct 2015 04:32:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsRaS-0002Yt-Kr for qemu-devel@nongnu.org; Sat, 31 Oct 2015 04:32:35 -0400 Received: from mga02.intel.com ([134.134.136.20]:48781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsRaS-0002Yp-FF for qemu-devel@nongnu.org; Sat, 31 Oct 2015 04:32:32 -0400 References: <1446184587-142784-1-git-send-email-guangrong.xiao@linux.intel.com> <1446184587-142784-8-git-send-email-guangrong.xiao@linux.intel.com> <20151030155454.GS4180@thinpad.lan.raisama.net> From: Xiao Guangrong Message-ID: <56347B10.3040305@linux.intel.com> Date: Sat, 31 Oct 2015 16:25:52 +0800 MIME-Version: 1.0 In-Reply-To: <20151030155454.GS4180@thinpad.lan.raisama.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 07/33] util: introduce qemu_file_get_page_size() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 10/30/2015 11:54 PM, Eduardo Habkost wrote: > On Fri, Oct 30, 2015 at 01:56:01PM +0800, Xiao Guangrong wrote: >> There are three places use the some logic to get the page size on >> the file path or file fd >> >> This patch introduces qemu_file_get_page_size() to unify the code >> >> Signed-off-by: Xiao Guangrong > [...] >> diff --git a/util/oslib-posix.c b/util/oslib-posix.c >> index 914cef5..ad94c5a 100644 >> --- a/util/oslib-posix.c >> +++ b/util/oslib-posix.c >> @@ -360,6 +360,22 @@ static size_t fd_getpagesize(int fd) >> return getpagesize(); >> } >> >> +size_t qemu_file_get_page_size(const char *path) >> +{ >> + size_t size = 0; >> + int fd = qemu_open(path, O_RDONLY); >> + >> + if (fd < 0) { >> + fprintf(stderr, "Could not open %s.\n", path); >> + goto exit; > > Have you considered using a Error** argument here? No. But it looks it a good way to detect error by check if Error is NULL. Will use it. :)