From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsaT4-0002sU-Rs for qemu-devel@nongnu.org; Sat, 31 Oct 2015 14:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsaT4-0007df-1T for qemu-devel@nongnu.org; Sat, 31 Oct 2015 14:01:30 -0400 References: <58456492c5ddcc4ae02a0b43ff4ed1d3d6d17308.1445600995.git.berto@igalia.com> From: Max Reitz Message-ID: <563501F1.7050804@redhat.com> Date: Sat, 31 Oct 2015 19:01:21 +0100 MIME-Version: 1.0 In-Reply-To: <58456492c5ddcc4ae02a0b43ff4ed1d3d6d17308.1445600995.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jNg3O895cnDw3V78HgXd5J6RS2J0CT1Io" Subject: Re: [Qemu-devel] [PATCH v3 3/4] block: Add 'x-blockdev-del' QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jNg3O895cnDw3V78HgXd5J6RS2J0CT1Io Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.10.2015 14:03, Alberto Garcia wrote: > This command is still experimental, hence the name. >=20 > This is the companion to 'blockdev-add'. It allows deleting a > BlockBackend with its associated BlockDriverState tree, or a > BlockDriverState that is not attached to any backend. >=20 > In either case, the command fails if the reference count is greater > than 1 or the BlockDriverState has any parents. >=20 > Signed-off-by: Alberto Garcia > --- > blockdev.c | 66 ++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qapi/block-core.json | 32 +++++++++++++++++++++++-- > qmp-commands.hx | 46 ++++++++++++++++++++++++++++++++++-- > 3 files changed, 140 insertions(+), 4 deletions(-) s/being used/in use/ might be better, and I don't think adding an associated blockdev-add to the example in qmp-commands.hx would hurt (stressing that they are intended to be paired; "virtio0" makes it look like blockdev-del is for deleting auto-generated BBs, too (which may work, but that doesn't seem to be its intended purpose)). Anyway: Reviewed-by: Max Reitz --jNg3O895cnDw3V78HgXd5J6RS2J0CT1Io Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWNQHxAAoJEDuxQgLoOKytOEQH/3l4L0xMkhib46Elb4s2Tput yNofLwNK/HKD+TI3YJv08ygkRNVr7u6OnGBXPw1ZBRsP+/wtxtVpTDP6YE69TnFu l2IB2E8tis2e3HHZcRdpGHwVRtr4wMSH2KRYkZDPpg7jHxONjKzoxTnz8AO/uSLL MtSlcV3TaFDYXBnOMWevWxYIJxMUyWP2mGEV+l91v1NDtvqrE/rSHMjLzWRPIqzr fVj5HvQULBUgK2NUIU6vLtcBK4/8xaT3zh/vQv0hBgo+8Cq3uOV3TpXub3XQ29if lJXgw8+9LGvgteTWuQxEMA9jBXMpqxZ8zGXh4QXjTUj3s3ZVLp6gMb0md6hjsh8= =lZDP -----END PGP SIGNATURE----- --jNg3O895cnDw3V78HgXd5J6RS2J0CT1Io--