From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsoje-0000Oy-FG for qemu-devel@nongnu.org; Sun, 01 Nov 2015 04:15:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zsoja-00046M-QS for qemu-devel@nongnu.org; Sun, 01 Nov 2015 04:15:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsoja-000468-Ga for qemu-devel@nongnu.org; Sun, 01 Nov 2015 04:15:30 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5076F5E for ; Sun, 1 Nov 2015 09:15:29 +0000 (UTC) References: <1446119788-19722-1-git-send-email-marcel@redhat.com> <20151030152048.GQ4180@thinpad.lan.raisama.net> From: Marcel Apfelbaum Message-ID: <5635D82C.6030400@redhat.com> Date: Sun, 1 Nov 2015 11:15:24 +0200 MIME-Version: 1.0 In-Reply-To: <20151030152048.GQ4180@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: kraxel@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 10/30/2015 05:20 PM, Eduardo Habkost wrote: > On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: > [...] >> index 095de5d..0a08531 100644 >> --- a/include/hw/compat.h >> +++ b/include/hw/compat.h >> @@ -2,7 +2,51 @@ >> #define HW_COMPAT_H >> >> #define HW_COMPAT_2_4 \ >> - /* empty */ >> + {\ >> + .driver = "virtio-blk-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ > > Why not a single virtio-pci.disable-pcie=on entry, instead of one entry > for each subclass? Hi, Thanks for pointing that out, that being said, I am a little embarrassed because I did think of it, but seeing HW_COMPAT 2_3 (any_layout) I assumed this would not work, my bad. By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio devices, not for all. Does anybody know if is in purpose or can we do the same for them too? I'll send an updated version shortly, Thanks Marcel > >> + },{\ >> + .driver = "virtio-scsi-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-net-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-input-host-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-keyboard-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-mouse-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-serial-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-tablet-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-gpu-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-balloon-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + },{\ >> + .driver = "virtio-rng-pci",\ >> + .property = "disable-pcie",\ >> + .value = "on",\ >> + }, >> >> #define HW_COMPAT_2_3 \ >> {\ >> -- >> 2.1.0 >> >