From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zt9tv-0005LB-Ti
	for qemu-devel@nongnu.org; Mon, 02 Nov 2015 02:51:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zt9tq-0002uI-R4
	for qemu-devel@nongnu.org; Mon, 02 Nov 2015 02:51:35 -0500
Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:37922)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Zt9tq-0002uE-K9
	for qemu-devel@nongnu.org; Mon, 02 Nov 2015 02:51:30 -0500
Received: by wmeg8 with SMTP id g8so52977835wme.1
	for <qemu-devel@nongnu.org>; Sun, 01 Nov 2015 23:51:29 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1446212690-7656-1-git-send-email-eduardo.otubo@profitbricks.com>
	<1446212690-7656-5-git-send-email-eduardo.otubo@profitbricks.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <563715FE.1050206@redhat.com>
Date: Mon, 2 Nov 2015 08:51:26 +0100
MIME-Version: 1.0
In-Reply-To: <1446212690-7656-5-git-send-email-eduardo.otubo@profitbricks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 04/05] seccomp: add setuid, setgid,
 chroot and setgroups to whitelist
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Otubo <eduardo.otubo@profitbricks.com>, qemu-devel@nongnu.org
Cc: Namsun Ch'o <namnamc@Safe-mail.net>, peter.maydell@linaro.org, drjones@redhat.com, dann.frazier@canonical.com



On 30/10/2015 14:44, Eduardo Otubo wrote:
> From: Namsun Ch'o <namnamc@Safe-mail.net>
> 
> The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are
> needed for -runas to work. It also doesn't whitelist chroot, which is needed
> for the -chroot option. Unfortunately, QEMU enables seccomp before it drops
> privileges or chroots, so without these whitelisted, -runas and -chroot cause
> QEMU to be killed with -sandbox on. This patch adds those syscalls.

I think this patch should not be applied, because it completely defeats
the purpose of the sandbox.  With these syscalls whitelisted, -runas and
-chroot have absolutely no effect against an attacker, even with
-sandbox on.

Paolo