From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtBIS-0000Um-US for qemu-devel@nongnu.org; Mon, 02 Nov 2015 04:21:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtBIN-000499-U0 for qemu-devel@nongnu.org; Mon, 02 Nov 2015 04:21:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtBIN-000493-JE for qemu-devel@nongnu.org; Mon, 02 Nov 2015 04:20:55 -0500 References: <1446119788-19722-1-git-send-email-marcel@redhat.com> <20151030152048.GQ4180@thinpad.lan.raisama.net> <5635D82C.6030400@redhat.com> <20151102100730.6836dc5f.cornelia.huck@de.ibm.com> From: Marcel Apfelbaum Message-ID: <56372AF2.8040500@redhat.com> Date: Mon, 2 Nov 2015 11:20:50 +0200 MIME-Version: 1.0 In-Reply-To: <20151102100730.6836dc5f.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, mst@redhat.com, Eduardo Habkost , kraxel@redhat.com On 11/02/2015 11:07 AM, Cornelia Huck wrote: > On Sun, 1 Nov 2015 11:15:24 +0200 > Marcel Apfelbaum wrote: > >> By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio devices, >> not for all. Does anybody know if is in purpose or can we do the same for them too? > > net and scsi already defaulted any_layout to true before. > > Are any others missing? > Hi, The whole list is: name "virtio-blk-pci", bus PCI, alias "virtio-blk" name "virtio-scsi-pci", bus PCI name "virtio-net-pci", bus PCI, alias "virtio-net" name "virtio-input-host-pci", bus PCI name "virtio-keyboard-pci", bus PCI name "virtio-mouse-pci", bus PCI name "virtio-serial-pci", bus PCI, alias "virtio-serial" name "virtio-tablet-pci", bus PCI name "virtio-gpu-pci", bus PCI name "virtio-balloon-pci", bus PCI, alias "virtio-balloon" name "virtio-rng-pci", bus PCI HW_COMPAT_2_3 has: - virtio-blk-pci - virtio-balloon-pci - virtio-serial-pci - virtio-9p-pci - virtio-rng-pci You mentioned: - virtio-scsi-pci - virtio-net-pci I guess the remaining list is: - virtio-input-host-pci - virtio-keyboard-pci - virtio-mouse-pci - virtio-tablet-pci - virtio-gpu-pci I don't know if is is applicable to them, or if they have it defaulted to any_layout, however the above devices are part of QEMU 2.3. Thanks, Marcel + },{\ + .driver = "virtio-scsi-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-net-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-input-host-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-keyboard-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-mouse-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-serial-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-tablet-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-gpu-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-balloon-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },{\ + .driver = "virtio-rng-pci",\ + .property = "disable-pcie",\ + .value = "on",\ + },