From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZtBvQ-0006Lb-QP
	for qemu-devel@nongnu.org; Mon, 02 Nov 2015 05:01:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZtBvL-00050f-EI
	for qemu-devel@nongnu.org; Mon, 02 Nov 2015 05:01:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41627)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZtBvL-00050b-8f
	for qemu-devel@nongnu.org; Mon, 02 Nov 2015 05:01:11 -0500
References: <1446119788-19722-1-git-send-email-marcel@redhat.com>
	<20151030152048.GQ4180@thinpad.lan.raisama.net>
	<5635D82C.6030400@redhat.com>
	<20151102100730.6836dc5f.cornelia.huck@de.ibm.com>
	<56372AF2.8040500@redhat.com>
	<20151102105425.32230aca.cornelia.huck@de.ibm.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <56373462.2050601@redhat.com>
Date: Mon, 2 Nov 2015 12:01:06 +0200
MIME-Version: 1.0
In-Reply-To: <20151102105425.32230aca.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to
 virtio devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, kraxel@redhat.com

On 11/02/2015 11:54 AM, Cornelia Huck wrote:
> On Mon, 2 Nov 2015 11:20:50 +0200
> Marcel Apfelbaum <marcel@redhat.com> wrote:
>
>> On 11/02/2015 11:07 AM, Cornelia Huck wrote:
>>> On Sun, 1 Nov 2015 11:15:24 +0200
>>> Marcel Apfelbaum <marcel@redhat.com> wrote:
>>>
>>>> By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio devices,
>>>> not for all. Does anybody know if is in purpose or can we do the same for them too?
>>>
>>> net and scsi already defaulted any_layout to true before.
>>>
>>> Are any others missing?
>>>
>>
>> Hi,
>>
>> The whole list is:
>>    name "virtio-blk-pci", bus PCI, alias "virtio-blk"
>>    name "virtio-scsi-pci", bus PCI
>>    name "virtio-net-pci", bus PCI, alias "virtio-net"
>>    name "virtio-input-host-pci", bus PCI
>>    name "virtio-keyboard-pci", bus PCI
>>    name "virtio-mouse-pci", bus PCI
>>    name "virtio-serial-pci", bus PCI, alias "virtio-serial"
>>    name "virtio-tablet-pci", bus PCI
>>    name "virtio-gpu-pci", bus PCI
>>    name "virtio-balloon-pci", bus PCI, alias "virtio-balloon"
>>    name "virtio-rng-pci", bus PCI
>>
>>
>> HW_COMPAT_2_3 has:
>>     - virtio-blk-pci
>>     - virtio-balloon-pci
>>     - virtio-serial-pci
>>     - virtio-9p-pci
>>     - virtio-rng-pci
>>
>> You mentioned:
>>     - virtio-scsi-pci
>>     - virtio-net-pci
>>
>> I guess the remaining list is:
>>    - virtio-input-host-pci
>>    - virtio-keyboard-pci
>>    - virtio-mouse-pci
>>    - virtio-tablet-pci
>>    - virtio-gpu-pci
>>
>> I don't know if is is applicable to them, or if they have it defaulted to any_layout,
>> however the above devices are part of QEMU 2.3.
>
> Hm, unless I'm fumbling git commands here, they were all added post-2.3?

I misspoke, I wanted to say that when I run (latest master branch):
  <qemu-bin>  -M pc-q35-2.3  -device help 2>&1 | grep virtio | grep pci
the devices are there.

>
> (And all of them seem to force virtio-1 anyway.)

OK. Thanks for looking into it!
Marcel


>