From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtDhm-0001kR-BQ for qemu-devel@nongnu.org; Mon, 02 Nov 2015 06:55:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtDhi-0000rQ-81 for qemu-devel@nongnu.org; Mon, 02 Nov 2015 06:55:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtDhi-0000rK-2M for qemu-devel@nongnu.org; Mon, 02 Nov 2015 06:55:14 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B48F38E67A for ; Mon, 2 Nov 2015 11:55:13 +0000 (UTC) References: <1446233769-7892-1-git-send-email-ehabkost@redhat.com> From: Paolo Bonzini Message-ID: <56374F1B.6010904@redhat.com> Date: Mon, 2 Nov 2015 12:55:07 +0100 MIME-Version: 1.0 In-Reply-To: <1446233769-7892-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RESEND v2 0/3] pc: Set hw_version on all machine classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Laszlo Ersek , "Michael S. Tsirkin" On 30/10/2015 20:36, Eduardo Habkost wrote: > In 2012, QEMU had a bug where it exposed QEMU version information > to the guest, meaning a QEMU upgrade would expose different > hardware to the guest OS even if the same machine-type is being > used. >=20 > The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, > on all machines up to pc-1.0. But we kept introducing the same > bug on all newer machines since then. That means we are breaking > guest ABI every time QEMU was upgraded. >=20 > Fix this by setting the hw_version on all PC machines, making > sure the hardware won't change when upgrading QEMU. >=20 > Eduardo Habkost (3): > pc: Set hw_version on all machine classes > osdep: Rename qemu_{get,set}_version() to qemu_{,set_}hw_version() > megasas: Use qemu_hw_version() instead of QEMU_VERSION >=20 > hw/arm/nseries.c | 2 +- > hw/i386/pc_piix.c | 13 +++++++++++++ > hw/i386/pc_q35.c | 10 ++++++++++ > hw/ide/core.c | 2 +- > hw/scsi/megasas.c | 2 +- > hw/scsi/scsi-bus.c | 2 +- > hw/scsi/scsi-disk.c | 2 +- > include/qemu/osdep.h | 4 ++-- > target-i386/cpu.c | 2 +- > util/osdep.c | 10 +++++----- > vl.c | 2 +- > 11 files changed, 37 insertions(+), 14 deletions(-) >=20 Michael, is it okay for you if I merge this patch series? Paolo