qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: disallow ccache during compile tests
Date: Mon, 2 Nov 2015 15:57:04 +0100	[thread overview]
Message-ID: <563779C0.5040804@redhat.com> (raw)
In-Reply-To: <1446055000-29150-1-git-send-email-jsnow@redhat.com>



On 28/10/2015 18:56, John Snow wrote:
> If the user is using CCACHE during the configuration step,
> it may interfere with some of the configuration tests,
> particularly the "Is CCACHE interfering with macro analysis" step,
> which is a bit of a poetic problem.
> 
> 1) Disallow CCACHE from reading from the cache during configure,
>    but don't disable it to allow us to see if it causes other problems.
> 
> 2) Force off CCACHE_CPP2 during the ccache test to get a deterministic
>    answer over whether or not we need to enable that feature later.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  configure | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/configure b/configure
> index 7a1d08d..9c726eb 100755
> --- a/configure
> +++ b/configure
> @@ -8,6 +8,9 @@
>  CLICOLOR_FORCE= GREP_OPTIONS=
>  unset CLICOLOR_FORCE GREP_OPTIONS
>  
> +# Don't allow CCACHE, if present, to use cached results of compile tests!
> +export CCACHE_RECACHE=yes
> +
>  # Temporary directory used for files created while
>  # configure runs. Since it is in the build directory
>  # we can safely blow away any previous version of it
> @@ -4412,6 +4415,7 @@ fi
>  # check if ccache is interfering with
>  # semantic analysis of macros
>  
> +unset CCACHE_CPP2
>  ccache_cpp2=no
>  cat > $TMPC << EOF
>  static const int Z = 1;
> 

Queued, thanks.

      parent reply	other threads:[~2015-11-02 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 17:56 [Qemu-devel] [PATCH] configure: disallow ccache during compile tests John Snow
2015-10-29  6:17 ` Markus Armbruster
2015-10-29 15:53   ` John Snow
2015-10-29 16:22     ` Markus Armbruster
2015-11-02 14:54       ` Paolo Bonzini
2015-11-02 14:57 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563779C0.5040804@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).