From: Eric Blake <eblake@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
"Gabriel L. Somlo" <somlo@cmu.edu>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, markmb@redhat.com, kraxel@redhat.com,
jordan.l.justen@intel.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 4/4] fw_cfg: streamline (non-DMA) read operations
Date: Mon, 2 Nov 2015 09:41:43 -0700 [thread overview]
Message-ID: <56379247.8020801@redhat.com> (raw)
In-Reply-To: <56377556.1020901@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On 11/02/2015 07:38 AM, Laszlo Ersek wrote:
>
> (1) Can you please split this patch in two? Maybe I'm just particularly
> slow today, but I feel that it would help me review this patch if I
> could look at each .read conversion in separation. I'd like to see that
> each conversion, individually, is unobservable from the guest.
>
> The first patch would introduce the new function and convert one of the
> callbacks. The second patch would convert the other callback and remove
> the old function. (Un-called static functions would break the compile,
> so the removal cannot be left for a third patch.)
You can mark static functions with __attribute__((__unused__)), and gcc
will then let you leave them for a later cleanup patch. I'm not sure if
clang behaves similarly, though.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-11-02 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 17:20 [Qemu-devel] [PATCH v2 0/4] fw_cfg: spec update, read optimization, misc. cleanup Gabriel L. Somlo
2015-10-28 17:20 ` [Qemu-devel] [PATCH v2 1/4] fw_cfg: move internal function call docs to header file Gabriel L. Somlo
2015-11-02 13:41 ` Laszlo Ersek
2015-11-02 20:36 ` Gabriel L. Somlo
2015-11-02 20:44 ` Laszlo Ersek
2015-10-28 17:20 ` [Qemu-devel] [PATCH v2 2/4] fw_cfg: amend callback behavior spec to once per select Gabriel L. Somlo
2015-11-02 14:16 ` Laszlo Ersek
2015-11-02 21:00 ` Gabriel L. Somlo
2015-10-28 17:20 ` [Qemu-devel] [PATCH v2 3/4] fw_cfg: remove offset argument from callback prototype Gabriel L. Somlo
2015-11-02 14:17 ` Laszlo Ersek
2015-10-28 17:20 ` [Qemu-devel] [PATCH v2 4/4] fw_cfg: streamline (non-DMA) read operations Gabriel L. Somlo
2015-11-02 14:38 ` Laszlo Ersek
2015-11-02 16:41 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56379247.8020801@redhat.com \
--to=eblake@redhat.com \
--cc=jordan.l.justen@intel.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=markmb@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).