From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtIB3-0007v1-EF for qemu-devel@nongnu.org; Mon, 02 Nov 2015 11:41:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtIAz-0006uN-8R for qemu-devel@nongnu.org; Mon, 02 Nov 2015 11:41:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtIAz-0006uD-2x for qemu-devel@nongnu.org; Mon, 02 Nov 2015 11:41:45 -0500 References: <1446052836-31737-1-git-send-email-somlo@cmu.edu> <1446052836-31737-5-git-send-email-somlo@cmu.edu> <56377556.1020901@redhat.com> From: Eric Blake Message-ID: <56379247.8020801@redhat.com> Date: Mon, 2 Nov 2015 09:41:43 -0700 MIME-Version: 1.0 In-Reply-To: <56377556.1020901@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q64JUgsivd0uabVvVnNuGjD9dCNWKMDhg" Subject: Re: [Qemu-devel] [PATCH v2 4/4] fw_cfg: streamline (non-DMA) read operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , "Gabriel L. Somlo" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, markmb@redhat.com, kraxel@redhat.com, jordan.l.justen@intel.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q64JUgsivd0uabVvVnNuGjD9dCNWKMDhg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/02/2015 07:38 AM, Laszlo Ersek wrote: >=20 > (1) Can you please split this patch in two? Maybe I'm just particularly= > slow today, but I feel that it would help me review this patch if I > could look at each .read conversion in separation. I'd like to see that= > each conversion, individually, is unobservable from the guest. >=20 > The first patch would introduce the new function and convert one of the= > callbacks. The second patch would convert the other callback and remove= > the old function. (Un-called static functions would break the compile, > so the removal cannot be left for a third patch.) You can mark static functions with __attribute__((__unused__)), and gcc will then let you leave them for a later cleanup patch. I'm not sure if clang behaves similarly, though. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Q64JUgsivd0uabVvVnNuGjD9dCNWKMDhg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWN5JHAAoJEKeha0olJ0NqeiIH/A+ivhQ50DJzOuGoZashc50w xEAd8ZRmBylSlb1Zk/HW8oSTfOlHNZXFOmxsZRodpCfHab7ZI3+wab0iDGvU+DQD SPWfEQKe1DXEFMI5S2NJjKrjI1VGGSIpXOtZeWgbCeniNj4ZNXlmk50LHrKD53O+ pqeP0SrXPd5cq8kvTS5rKtuuPaVUSUff4qMiIs96AN0byv8lk9l4yjvw7DIYFRkW Ifh96jHpM5kzaH6SyuqlZUkHMEIL0fKFs31jLzebaTsTlAfzh0GtvS6t588SKS7q wR90tqMbB+hX4EJBRrVF2LNb8bmDIpFZ2e5XfJpTqr/mbBhzIVygwHQHVsoiFDQ= =4rS6 -----END PGP SIGNATURE----- --Q64JUgsivd0uabVvVnNuGjD9dCNWKMDhg--