From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtIZj-0000UV-1l for qemu-devel@nongnu.org; Mon, 02 Nov 2015 12:07:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtIZh-0004AY-Vv for qemu-devel@nongnu.org; Mon, 02 Nov 2015 12:07:18 -0500 References: <44b88beb06a7c6086753fcc65770db826472b8cd.1446465949.git.berto@igalia.com> From: Max Reitz Message-ID: <5637983D.8090303@redhat.com> Date: Mon, 2 Nov 2015 18:07:09 +0100 MIME-Version: 1.0 In-Reply-To: <44b88beb06a7c6086753fcc65770db826472b8cd.1446465949.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xipVLRkbRFTf8MEmqCWoGifwIMqOQ5beu" Subject: Re: [Qemu-devel] [PATCH v2 2/2] block: test 'blockdev-snapshot' using a file BDS as the overlay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xipVLRkbRFTf8MEmqCWoGifwIMqOQ5beu Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 02.11.2015 13:15, Alberto Garcia wrote: > This test checks that it is not possible to create a snapshot using as > the overlay node a BDS that does not support backing images. I don't think that works in English. I may be wrong, of course. "a snapshot using a BDS that does not support backing images as the overlay node", "a snapshot with the overlay node being a BDS that...", "a snapshot using a BDS as the overlay node that...", or something like that might work. > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/085 | 12 +++++++++++- > tests/qemu-iotests/085.out | 4 ++++ > 2 files changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 > index 9484117..ccde2ae 100755 > --- a/tests/qemu-iotests/085 > +++ b/tests/qemu-iotests/085 > @@ -103,7 +103,8 @@ function add_snapshot_image() > { 'options': > { 'driver': 'qcow2', 'node-name': 'snap_"${1}"', "${extra= _params}" > 'file': > - { 'driver': 'file', 'filename': '"${snapshot_file}"' } = } } }" > + { 'driver': 'file', 'filename': '"${snapshot_file}"', > + 'node-name': 'file_"${1}"' } } } }" Pre-existing, but do those "" actually do anything? Since the latter is mainly out of curiosity, and because English too not my mother language is, which is why I not the one be should, who himself over that complains*: Reviewed-by: Max Reitz (Although I would indeed prefer the commit message to be parsable more easily.) *Man, writing that was hard. > _send_qemu_cmd $h "${cmd}" "return" > } > =20 > @@ -187,6 +188,15 @@ add_snapshot_image ${SNAPSHOTS} > blockdev_snapshot ${SNAPSHOTS} > =20 > echo > +echo =3D=3D=3D Invalid command - cannot create a snapshot using a file= BDS =3D=3D=3D > +echo > + > +_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot', > + 'arguments': { 'node':'virtio0', > + 'overlay':'file_"${SNAPSHOTS}"' } > + }" "error" > + > +echo > echo =3D=3D=3D Invalid command - snapshot node used as active layer =3D= =3D=3D > echo > =20 > diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out > index 52292ea..01c78d6 100644 > --- a/tests/qemu-iotests/085.out > +++ b/tests/qemu-iotests/085.out > @@ -62,6 +62,10 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D= 134217728 backing_file=3DTEST_DIR/ > {"return": {}} > {"return": {}} > =20 > +=3D=3D=3D Invalid command - cannot create a snapshot using a file BDS = =3D=3D=3D > + > +{"error": {"class": "GenericError", "desc": "The snapshot does not sup= port backing images"}} > + > =3D=3D=3D Invalid command - snapshot node used as active layer =3D=3D=3D= > =20 > {"error": {"class": "GenericError", "desc": "The snapshot is already i= n use by virtio0"}} >=20 --xipVLRkbRFTf8MEmqCWoGifwIMqOQ5beu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWN5g9AAoJEDuxQgLoOKyt+jgH/31KHkUiXWtXMn8aqGEyTNgF cXjfu2vWNSKvYpazaqE702rJJSireoqy5nyDl32cNT49RJCYov2fZSzg2pOioQrC CLWEUUOss3KldAgH6pIzq1rAnvC2oan+fGmcHELDthwNVuvKDmObg0FCSjTxpfY9 CtTxWcbjT0Pl+Sd2o34hkYPzUebvb+DnC1jl2Vnh3QEiPecPaTBIffEJ972eHlHO cg+rYv+jRhaffov7EJum3yM4zKGzO1y8H5aKL5Bdn/nv8bYFlCN52lF2emwEL81W g1zt3v8m6RjYoVFaeJiU2Kv67DUfV6JAjSYarGfpdEU35TTqahnQ532tWy4xSXw= =LLU2 -----END PGP SIGNATURE----- --xipVLRkbRFTf8MEmqCWoGifwIMqOQ5beu--