From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtIv5-0007CA-Nh for qemu-devel@nongnu.org; Mon, 02 Nov 2015 12:29:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtIv4-0000Em-OA for qemu-devel@nongnu.org; Mon, 02 Nov 2015 12:29:23 -0500 References: <44b88beb06a7c6086753fcc65770db826472b8cd.1446465949.git.berto@igalia.com> <5637983D.8090303@redhat.com> From: Eric Blake Message-ID: <56379D6A.3000101@redhat.com> Date: Mon, 2 Nov 2015 10:29:14 -0700 MIME-Version: 1.0 In-Reply-To: <5637983D.8090303@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A9VHcddFUiA6TAXHIQas1WMU3RwKVNUK7" Subject: Re: [Qemu-devel] [PATCH v2 2/2] block: test 'blockdev-snapshot' using a file BDS as the overlay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --A9VHcddFUiA6TAXHIQas1WMU3RwKVNUK7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/02/2015 10:07 AM, Max Reitz wrote: > On 02.11.2015 13:15, Alberto Garcia wrote: >> This test checks that it is not possible to create a snapshot using as= >> the overlay node a BDS that does not support backing images. >=20 > I don't think that works in English. I may be wrong, of course. >=20 > "a snapshot using a BDS that does not support backing images as the > overlay node", "a snapshot with the overlay node being a BDS that...", > "a snapshot using a BDS as the overlay node that...", or something like= > that might work. >=20 How about: This test checks that it is not possible to create a snapshot if the requested overlay node is a BDS which does not support backing images. >> +++ b/tests/qemu-iotests/085 >> @@ -103,7 +103,8 @@ function add_snapshot_image() >> { 'options': >> { 'driver': 'qcow2', 'node-name': 'snap_"${1}"', "${extr= a_params}" >> 'file': >> - { 'driver': 'file', 'filename': '"${snapshot_file}"' }= } } }" >> + { 'driver': 'file', 'filename': '"${snapshot_file}"', >> + 'node-name': 'file_"${1}"' } } } }" >=20 > Pre-existing, but do those "" actually do anything? >=20 Actually, the "" are wrong. Look at the full context: we have: cmd=3D"..."${snapshot_file}"..." which means the expansion of $snapshot_file is _unquoted_. We really want either: cmd=3D'...'"${snapshot_file}"'...' (if we wanted to write the command with " instead of ' for internal string quoting), or: cmd=3D"...${snapshot_file}..." I suspect that it crept in because locally we have ' in the ..., and '${...}' in isolation is usually wrong (which is why you have to look at the full string, and not just the local change). > Since the latter is mainly out of curiosity, and because English too no= t > my mother language is, which is why I not the one be should, who himsel= f > over that complains*: LOL --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --A9VHcddFUiA6TAXHIQas1WMU3RwKVNUK7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWN51rAAoJEKeha0olJ0NqKRUIAIY5XAJBrrzwep7XeNJBdunz WnSz9M9pW3ig7CCC4lBKTxEBoxkoYgPBxlxD1Y6pRrpaJeZgPIqMFK3AxL98V4iE 1sm388B1JR0fXkA/UnF+Zh5NRZl/hIVLC60/WQFDUeN7JZ9VsGZmLpj1bXH48Pvv PvCqdOLEjHiOQKNwly3yRcnQNKQ2wQgzU0RucqNfHYuSSqjVApkN7ptYLeVJZ1TR v+TXSQUuiWBM0RaQYrV7IEBv1yKeejPuicJBmtKmc9dMnakZGA3LJqWsdqPgw1c9 YMgkbb4XhCaFhsd/II4UyhPAJyJBpjJ9JufhacYQ/PbGt1WrOVKgjXmOJzjB6Ew= =ixif -----END PGP SIGNATURE----- --A9VHcddFUiA6TAXHIQas1WMU3RwKVNUK7--