From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtLBg-0002eK-2C for qemu-devel@nongnu.org; Mon, 02 Nov 2015 14:54:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtLBf-0004Hb-2P for qemu-devel@nongnu.org; Mon, 02 Nov 2015 14:54:39 -0500 References: <1445902682-20051-1-git-send-email-jsnow@redhat.com> <20151027165015.GA9986@stefanha-x1.localdomain> From: John Snow Message-ID: <5637BF78.8040808@redhat.com> Date: Mon, 2 Nov 2015 14:54:32 -0500 MIME-Version: 1.0 In-Reply-To: <20151027165015.GA9986@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ide: remove hardcoded 2GiB transactional limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On 10/27/2015 12:50 PM, Stefan Hajnoczi wrote: > On Mon, Oct 26, 2015 at 07:38:02PM -0400, John Snow wrote: >> Not that you can request a >2GiB transaction, but that's why checking >> for it makes no sense anymore. >> >> With the newer 'limit' parameter to prepare_buf, we no longer need a >> static limit. The maximum limit is still 2GiB, but the limit parameter >> is set to the current transaction size, which cannot surpass 32MiB >> (512 * 65536). If the PRDT surpasses the transactional size, then, >> we'll just carry out the normative underflow handling pathways instead >> of needing an extra, strange pathway that worries about hitting some >> logistical cap for the largest sglist we can support -- we'll never >> even attempt to build one that big anymore. >> >> Reported-by: Kevin Wolf >> Signed-off-by: John Snow >> --- >> hw/ide/ahci.c | 30 ++++++++++++++---------------- >> hw/ide/internal.h | 2 +- >> hw/ide/pci.c | 7 ------- >> 3 files changed, 15 insertions(+), 24 deletions(-) > > Acked-by: Stefan Hajnoczi > Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js