From: Max Reitz <mreitz@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/2] qemu-iotests: fix cleanup of background processes
Date: Mon, 2 Nov 2015 21:35:27 +0100 [thread overview]
Message-ID: <5637C90F.3070408@redhat.com> (raw)
In-Reply-To: <5637C813.2050902@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
On 02.11.2015 21:31, Max Reitz wrote:
> On 30.10.2015 20:25, Jeff Cody wrote:
>> Changes from v2:
>>
>> * Pulled patch 2 into this series
>>
>> * Patch 1: Moved non-empty test conditionals inside
>> pid file existance check (thanks Max)
>>
>> Added a fix in for patch 058, for its
>> self-launched qemu-nbd instance (thanks Max)
>>
>> * Patch 2: Only print the valgrind logs if the exit error
>> matches (thanks Max)
>>
>> Changes from v1:
>>
>> * use 'read' instead of 'cat' (thanks Eric)
>> * quote variable in variable test (thanks Eric)
>>
>> Jeff Cody (2):
>> qemu-iotests: fix cleanup of background processes
>> qemu-iotests: fix -valgrind option for check
>>
>> tests/qemu-iotests/039.out | 30 +++++++++++++++++++++++++-----
>> tests/qemu-iotests/058 | 12 ++++++++----
>> tests/qemu-iotests/061.out | 12 ++++++++++--
>> tests/qemu-iotests/137.out | 6 +++++-
>> tests/qemu-iotests/common | 9 ++-------
>> tests/qemu-iotests/common.config | 32 +++++++++++++++++++++++++++++---
>> tests/qemu-iotests/common.qemu | 18 ++++++++++++------
>> tests/qemu-iotests/common.rc | 18 +++++-------------
>> 8 files changed, 96 insertions(+), 41 deletions(-)
>
> Thanks, applied to my block tree with the three occurrences of ! -n in
> patch 1 changed to -z:
Err, of course it's the other way around, ! -z to -n.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-11-02 20:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 19:25 [Qemu-devel] [PATCH v3 0/2] qemu-iotests: fix cleanup of background processes Jeff Cody
2015-10-30 19:25 ` [Qemu-devel] [PATCH v3 1/2] " Jeff Cody
2015-10-30 21:13 ` Max Reitz
2015-11-02 7:37 ` Markus Armbruster
2015-11-02 16:03 ` Max Reitz
2015-11-02 16:32 ` Eric Blake
2015-10-30 19:25 ` [Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option for check Jeff Cody
2015-10-30 21:14 ` Max Reitz
2015-11-02 20:31 ` [Qemu-devel] [PATCH v3 0/2] qemu-iotests: fix cleanup of background processes Max Reitz
2015-11-02 20:35 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5637C90F.3070408@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).