From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtVmT-0000vy-Iv for qemu-devel@nongnu.org; Tue, 03 Nov 2015 02:13:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtVmP-0000Hz-I4 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 02:13:21 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:36213 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtVmP-0000Hm-81 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 02:13:17 -0500 References: <1446203414-4013-1-git-send-email-kraxel@redhat.com> From: Peter Lieven Message-ID: <56385E87.6070807@kamp.de> Date: Tue, 3 Nov 2015 08:13:11 +0100 MIME-Version: 1.0 In-Reply-To: <1446203414-4013-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/19] buffer/vnc: improve vnc buffer hsndling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Am 30.10.2015 um 12:09 schrieb Gerd Hoffmann: > Hi, > > This series has a bunch of improvements in the vnc buffer handling, > to reduce the memory footprint. Some of the changes are applied to > the buffer helper functions which Daniel separated out of the vnc code > recently. > > Most patches have been on the list before, based on a older version of > Daniel's "separate out buffer code" patches. Now I finally managed to > rebase and adapt the changes to the latest version which landed in > master meanwhile. I don't expect major issues showing up here and plan > to have a pull request with this in time for 2.5-rc0. > > Peter, if you have anything pending not yet in here please rebase and > resend. > > please review, > Gerd > > Gerd Hoffmann (14): > buffer: add buffer_init > buffer: add buffer_move_empty > buffer: add buffer_move > buffer: add buffer_shrink > buffer: add tracing > vnc: attach names to buffers > vnc: kill jobs queue buffer > vnc-jobs: move buffer reset, use new buffer move > vnc: zap dead code > vnc: add vnc_width+vnc_height helpers > vnc: factor out vnc_update_server_surface > vnc: use vnc_{width,height} in vnc_set_area_dirty > vnc: only alloc server surface with clients connected > vnc: fix local state init All above: Reviewed-by: Peter Lieven > > Peter Lieven (5): > buffer: make the Buffer capacity increase in powers of two > vnc: recycle empty vs->output buffer > buffer: factor out buffer_req_size > buffer: factor out buffer_adj_size > buffer: allow a buffer to shrink gracefully The last Patch isn't the latest version. I have one with improved comments here: https://github.com/plieven/qemu/commit/e599748ab1ef381d4b1c88bf1ea1454dd89353fb I also had another improvement: https://github.com/plieven/qemu/commit/2b4180a5f4ec29a59de692e9aa512b7b4d8023e7 which limits the number of memmove operation in qio_buffer_advance. Peter