From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtbjI-0003Hd-59 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 08:34:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtbjF-0003up-0A for qemu-devel@nongnu.org; Tue, 03 Nov 2015 08:34:28 -0500 Received: from mga02.intel.com ([134.134.136.20]:64005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtbjE-0003tb-Qs for qemu-devel@nongnu.org; Tue, 03 Nov 2015 08:34:24 -0500 References: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com> <1446455617-129562-7-git-send-email-guangrong.xiao@linux.intel.com> <20151103133032.21fd13c4@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: <5638B641.2050509@linux.intel.com> Date: Tue, 3 Nov 2015 21:27:29 +0800 MIME-Version: 1.0 In-Reply-To: <20151103133032.21fd13c4@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 06/35] acpi: add aml_method_serialized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: vsementsov@virtuozzo.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/03/2015 08:30 PM, Igor Mammedov wrote: > On Mon, 2 Nov 2015 17:13:08 +0800 > Xiao Guangrong wrote: > >> It avoid explicit Mutex and will be used by NVDIMM ACPI >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/aml-build.c | 26 ++++++++++++++++++++++++-- >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 25 insertions(+), 2 deletions(-) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 9f792ab..8bee8b2 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -696,14 +696,36 @@ Aml *aml_while(Aml *predicate) >> } >> >> /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */ >> -Aml *aml_method(const char *name, int arg_count) >> +static Aml *__aml_method(const char *name, int arg_count, bool serialized) > We don't have many users of aml_method() yet, so I'd prefer to have a single > vs multiple function call: > > I suggest to do something like: > typedef enum { > AML_NONSERIALIZED = 0, > AML_SERIALIZED = 1, > } AmlSerializeRule; > > aml_method(const char *name, AmlSerializeRule rule, int synclevel); > > with current users fixed up with AML_NONSERIALIZED argument. Okay. It looks good to me, will follow it.